New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Route Handling Example for CSP Violations #16

Merged
merged 2 commits into from May 14, 2015

Conversation

Projects
None yet
2 participants
@dstroot
Contributor

dstroot commented May 5, 2015

Added to the readme so people can see how to implement the route handling for CSP violations. Cheers!

@EvanHahn

This comment has been minimized.

Show comment
Hide comment
@EvanHahn

EvanHahn May 5, 2015

Member

This seems like two separate issues: (1) here's an example handler for CSP violations (2) here's a bug you might encounter with csurf.

What do you think? If you agree, could you reorganize this to reflect that? I imagine the example would come before the csurf note.

Member

EvanHahn commented May 5, 2015

This seems like two separate issues: (1) here's an example handler for CSP violations (2) here's a bug you might encounter with csurf.

What do you think? If you agree, could you reorganize this to reflect that? I imagine the example would come before the csurf note.

@dstroot

This comment has been minimized.

Show comment
Hide comment
@dstroot

dstroot May 5, 2015

Contributor

Yup - agree. I'm out of town until the weekend. Will tackle it then. Good feedback.

On May 5, 2015, at 1:30 PM, Evan Hahn notifications@github.com wrote:

This seems like two separate issues: (1) here's an example handler for CSP violations (2) here's a bug you might encounter with csurf.

What do you think? If you agree, could you reorganize this to reflect that? I imagine the example would come before the csurf note.


Reply to this email directly or view it on GitHub.

Contributor

dstroot commented May 5, 2015

Yup - agree. I'm out of town until the weekend. Will tackle it then. Good feedback.

On May 5, 2015, at 1:30 PM, Evan Hahn notifications@github.com wrote:

This seems like two separate issues: (1) here's an example handler for CSP violations (2) here's a bug you might encounter with csurf.

What do you think? If you agree, could you reorganize this to reflect that? I imagine the example would come before the csurf note.


Reply to this email directly or view it on GitHub.

@EvanHahn

This comment has been minimized.

Show comment
Hide comment
@EvanHahn

EvanHahn May 5, 2015

Member

👍

Member

EvanHahn commented May 5, 2015

👍

@dstroot

This comment has been minimized.

Show comment
Hide comment
@dstroot

dstroot May 12, 2015

Contributor

Updated as requested. I have no more time to spend on this so if you want it tweaked further you are on your own. ;)

Cheers!

Contributor

dstroot commented May 12, 2015

Updated as requested. I have no more time to spend on this so if you want it tweaked further you are on your own. ;)

Cheers!

@EvanHahn

This comment has been minimized.

Show comment
Hide comment
@EvanHahn

EvanHahn May 12, 2015

Member

Thanks! I'll tweak and merge.

Member

EvanHahn commented May 12, 2015

Thanks! I'll tweak and merge.

@EvanHahn EvanHahn merged commit 1ad65a8 into helmetjs:master May 14, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@EvanHahn

This comment has been minimized.

Show comment
Hide comment
@EvanHahn

EvanHahn Aug 5, 2016

Member

I'm making a new website for Helmet.js and I want to credit everyone who's contributed. Do you have a name and/or website you'd like me to use to credit you?

Member

EvanHahn commented Aug 5, 2016

I'm making a new website for Helmet.js and I want to credit everyone who's contributed. Do you have a name and/or website you'd like me to use to credit you?

@dstroot

This comment has been minimized.

Show comment
Hide comment
@dstroot

dstroot Aug 6, 2016

Contributor

That's generous. Just use "Dan Stroot"

Contributor

dstroot commented Aug 6, 2016

That's generous. Just use "Dan Stroot"

@EvanHahn

This comment has been minimized.

Show comment
Hide comment
@EvanHahn

EvanHahn Aug 6, 2016

Member

Added you to the list! Stay tuned for the new Helmet website.

Member

EvanHahn commented Aug 6, 2016

Added you to the list! Stay tuned for the new Helmet website.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment