New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable dynamically generated values #26

Merged
merged 2 commits into from Dec 18, 2015

Conversation

Projects
None yet
2 participants
@nickclaw
Contributor

nickclaw commented Nov 12, 2015

No description provided.

@nickclaw

This comment has been minimized.

Show comment
Hide comment
@nickclaw

nickclaw Dec 2, 2015

Contributor

Ping @EvanHahn

Contributor

nickclaw commented Dec 2, 2015

Ping @EvanHahn

@EvanHahn

This comment has been minimized.

Show comment
Hide comment
@EvanHahn

EvanHahn Dec 3, 2015

Member

@nickclaw Sorry to have let this linger. I'll get this merged soon.

Member

EvanHahn commented Dec 3, 2015

@nickclaw Sorry to have let this linger. I'll get this merged soon.

Show outdated Hide outdated index.js Outdated
Show outdated Hide outdated index.js Outdated
Show outdated Hide outdated index.js Outdated
Show outdated Hide outdated index.js Outdated
Show outdated Hide outdated index.js Outdated
Show outdated Hide outdated index.js Outdated
Show outdated Hide outdated README.md Outdated
Show outdated Hide outdated README.md Outdated
Show outdated Hide outdated README.md Outdated
Show outdated Hide outdated README.md Outdated
@EvanHahn

This comment has been minimized.

Show comment
Hide comment
@EvanHahn

EvanHahn Dec 6, 2015

Member

@nickclaw Just left a bunch of comments. They're mostly nitpicks—this is a great PR!

Member

EvanHahn commented Dec 6, 2015

@nickclaw Just left a bunch of comments. They're mostly nitpicks—this is a great PR!

@nickclaw

This comment has been minimized.

Show comment
Hide comment
@nickclaw

nickclaw Dec 8, 2015

Contributor

Sounds good! I'll address all those issue sometime tomorrow and ping you again.

Contributor

nickclaw commented Dec 8, 2015

Sounds good! I'll address all those issue sometime tomorrow and ping you again.

@nickclaw

This comment has been minimized.

Show comment
Hide comment
@nickclaw

nickclaw Dec 8, 2015

Contributor

@EvanHahn Should be good to merge, let me know if you want me to flatten it or anything

Contributor

nickclaw commented Dec 8, 2015

@EvanHahn Should be good to merge, let me know if you want me to flatten it or anything

@nickclaw

This comment has been minimized.

Show comment
Hide comment
@nickclaw

nickclaw Dec 16, 2015

Contributor

@EvanHahn had a chance to look at this yet?

Contributor

nickclaw commented Dec 16, 2015

@EvanHahn had a chance to look at this yet?

@EvanHahn

This comment has been minimized.

Show comment
Hide comment
@EvanHahn

EvanHahn Dec 16, 2015

Member

@nickclaw I have—sorry to be slow to get to this! I'll get this settled on Friday.

Member

EvanHahn commented Dec 16, 2015

@nickclaw I have—sorry to be slow to get to this! I'll get this settled on Friday.

EvanHahn added a commit that referenced this pull request Dec 18, 2015

Merge pull request #26 from nickclaw/master
Enable dynamically generated values

@EvanHahn EvanHahn merged commit c2d8a53 into helmetjs:master Dec 18, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@EvanHahn

This comment has been minimized.

Show comment
Hide comment
@EvanHahn

EvanHahn Dec 18, 2015

Member

@nickclaw I've merged this. I'm gonna do a little work on this and then release 1.0.0!

Member

EvanHahn commented Dec 18, 2015

@nickclaw I've merged this. I'm gonna do a little work on this and then release 1.0.0!

@EvanHahn

This comment has been minimized.

Show comment
Hide comment
@EvanHahn

EvanHahn Aug 5, 2016

Member

I'm making a new website for Helmet.js and I want to credit everyone who's contributed. Do you have a name and/or website you'd like me to use to credit you?

I'll also credit you for #30.

Member

EvanHahn commented Aug 5, 2016

I'm making a new website for Helmet.js and I want to credit everyone who's contributed. Do you have a name and/or website you'd like me to use to credit you?

I'll also credit you for #30.

@nickclaw

This comment has been minimized.

Show comment
Hide comment
@nickclaw

nickclaw Aug 5, 2016

Contributor

Cool idea! You can put my name down as Nicholas Clawson and website as www.nickclaw.com

Contributor

nickclaw commented Aug 5, 2016

Cool idea! You can put my name down as Nicholas Clawson and website as www.nickclaw.com

@EvanHahn

This comment has been minimized.

Show comment
Hide comment
@EvanHahn

EvanHahn Aug 6, 2016

Member

Will do! Stay tuned for the new Helmet website.

Member

EvanHahn commented Aug 6, 2016

Will do! Stay tuned for the new Helmet website.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment