New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug: a request from unknown browsers change global setAllHeaders setting #4

Merged
merged 1 commit into from Nov 9, 2014

Conversation

Projects
None yet
2 participants
@teppeis
Contributor

teppeis commented Nov 9, 2014

After receiving a request from unknown browsers, all headers are send to any browser.

@EvanHahn

This comment has been minimized.

Show comment
Hide comment
@EvanHahn

EvanHahn Nov 9, 2014

Member

Good catch! Going to make sure this works and then I'll merge. Thank you!

Member

EvanHahn commented Nov 9, 2014

Good catch! Going to make sure this works and then I'll merge. Thank you!

EvanHahn added a commit that referenced this pull request Nov 9, 2014

Merge pull request #4 from teppeis/fix-setallheaders
Fix bug: a request from unknown browsers change global setAllHeaders setting

@EvanHahn EvanHahn merged commit c1ac73b into helmetjs:master Nov 9, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@EvanHahn

This comment has been minimized.

Show comment
Hide comment
@EvanHahn

EvanHahn Nov 9, 2014

Member

Bumped helmet-csp to 0.1.1 and helmet to 0.5.1. Thanks!

Member

EvanHahn commented Nov 9, 2014

Bumped helmet-csp to 0.1.1 and helmet to 0.5.1. Thanks!

@teppeis teppeis deleted the teppeis:fix-setallheaders branch Nov 9, 2014

@teppeis

This comment has been minimized.

Show comment
Hide comment
@teppeis

teppeis Nov 9, 2014

Contributor

thanks!

Contributor

teppeis commented Nov 9, 2014

thanks!

@EvanHahn

This comment has been minimized.

Show comment
Hide comment
@EvanHahn

EvanHahn Aug 5, 2016

Member

I'm making a new website for Helmet.js and I want to credit everyone who's contributed. Do you have a name and/or website you'd like me to use to credit you?

Member

EvanHahn commented Aug 5, 2016

I'm making a new website for Helmet.js and I want to credit everyone who's contributed. Do you have a name and/or website you'd like me to use to credit you?

@EvanHahn

This comment has been minimized.

Show comment
Hide comment
@EvanHahn

EvanHahn Aug 5, 2016

Member

(I'll credit you for #5, too.)

Member

EvanHahn commented Aug 5, 2016

(I'll credit you for #5, too.)

@teppeis

This comment has been minimized.

Show comment
Hide comment
@teppeis

teppeis Aug 8, 2016

Contributor

@EvanHahn Thanks! Please credit me as "Teppei Sato (@teppeis)".

Contributor

teppeis commented Aug 8, 2016

@EvanHahn Thanks! Please credit me as "Teppei Sato (@teppeis)".

@EvanHahn

This comment has been minimized.

Show comment
Hide comment
@EvanHahn

EvanHahn Aug 11, 2016

Member

Will do! Stay tuned for the new Helmet website.

Member

EvanHahn commented Aug 11, 2016

Will do! Stay tuned for the new Helmet website.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment