New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Firefox for Android and Firefox OS #43

Merged
merged 1 commit into from Jul 27, 2016

Conversation

Projects
None yet
2 participants
@shane-tomlinson
Contributor

shane-tomlinson commented Jul 20, 2016

fixes #42

@EvanHahn

This comment has been minimized.

Show comment
Hide comment
@EvanHahn

EvanHahn Jul 20, 2016

Member

I looked over your tests and the fact that this all passes is good. I'll take a look at all the source code soon!

Member

EvanHahn commented Jul 20, 2016

I looked over your tests and the fact that this all passes is good. I'll take a look at all the source code soon!

@shane-tomlinson

This comment has been minimized.

Show comment
Hide comment
@shane-tomlinson

shane-tomlinson Jul 20, 2016

Contributor

Thanks @EvanHahn - I'm learning my way around the code base and your conventions, I'm not afraid of a strict review. :D

Contributor

shane-tomlinson commented Jul 20, 2016

Thanks @EvanHahn - I'm learning my way around the code base and your conventions, I'm not afraid of a strict review. :D

@EvanHahn

This comment has been minimized.

Show comment
Hide comment
@EvanHahn

EvanHahn Jul 21, 2016

Member

Looks good other than my minor comments!

Member

EvanHahn commented Jul 21, 2016

Looks good other than my minor comments!

@EvanHahn

This comment has been minimized.

Show comment
Hide comment
@EvanHahn

EvanHahn Jul 21, 2016

Member

By the way: I'd like to make Helmet easier to contribute to. Did you run into any challenges? Anything you'd change to make it friendlier?

Member

EvanHahn commented Jul 21, 2016

By the way: I'd like to make Helmet easier to contribute to. Did you run into any challenges? Anything you'd change to make it friendlier?

@shane-tomlinson

This comment has been minimized.

Show comment
Hide comment
@shane-tomlinson

shane-tomlinson Jul 22, 2016

Contributor

Thanks for the feedback @EvanHahn! I have made the requested updates, I agree it looks cleaner this way.

Did you run into any challenges? Anything you'd change to make it friendlier?

The hardest part for me was not a problem with anything here, but was digging through Bugzilla to find out which versions of Firefox for Android and Firefox OS supported which CSP headers. The JS Standard style takes a bit getting used to, but nothing too surprising.

Contributor

shane-tomlinson commented Jul 22, 2016

Thanks for the feedback @EvanHahn! I have made the requested updates, I agree it looks cleaner this way.

Did you run into any challenges? Anything you'd change to make it friendlier?

The hardest part for me was not a problem with anything here, but was digging through Bugzilla to find out which versions of Firefox for Android and Firefox OS supported which CSP headers. The JS Standard style takes a bit getting used to, but nothing too surprising.

@EvanHahn EvanHahn merged commit dc68518 into helmetjs:master Jul 27, 2016

2 checks passed

Node Security No known vulnerabilities found
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@EvanHahn

This comment has been minimized.

Show comment
Hide comment
@EvanHahn

EvanHahn Jul 27, 2016

Member

Thanks! This has been released in helmet-csp@1.2.2 and helmet@2.1.2.

I'm planning on starting a list of contributors (probably just a big list of bullet points). How should I credit you?

Member

EvanHahn commented Jul 27, 2016

Thanks! This has been released in helmet-csp@1.2.2 and helmet@2.1.2.

I'm planning on starting a list of contributors (probably just a big list of bullet points). How should I credit you?

@shane-tomlinson shane-tomlinson deleted the shane-tomlinson:issue-42-fx-mobile-os-xhr-src branch Jul 28, 2016

@shane-tomlinson

This comment has been minimized.

Show comment
Hide comment
@shane-tomlinson

shane-tomlinson Jul 28, 2016

Contributor

I'm planning on starting a list of contributors (probably just a big list of bullet points). How should I credit you?

Thanks! You choose the format, my details are: Shane Tomlinson <shane@shanetomlinson.com>

Contributor

shane-tomlinson commented Jul 28, 2016

I'm planning on starting a list of contributors (probably just a big list of bullet points). How should I credit you?

Thanks! You choose the format, my details are: Shane Tomlinson <shane@shanetomlinson.com>

@EvanHahn EvanHahn referenced this pull request Aug 5, 2016

Closed

Add list of contributors #1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment