New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added warning for lack of browser support for the ALLOW-FROM option #4

Merged
merged 3 commits into from Jun 5, 2015

Conversation

Projects
None yet
2 participants
@EvanHahn

This comment has been minimized.

Show comment
Hide comment
@EvanHahn

EvanHahn Jun 4, 2015

Member

Great addition. Could you add a link to that MDN article in your PR?

Member

EvanHahn commented Jun 4, 2015

Great addition. Could you add a link to that MDN article in your PR?

@eligolding

This comment has been minimized.

Show comment
Hide comment
@eligolding

eligolding Jun 4, 2015

Contributor

Done. I also added a link to OWASP's Clickjacking Defense Cheat Sheet that explicitly says that you will have no clickjacking defense if used in unsupported browser.

Contributor

eligolding commented Jun 4, 2015

Done. I also added a link to OWASP's Clickjacking Defense Cheat Sheet that explicitly says that you will have no clickjacking defense if used in unsupported browser.

Show outdated Hide outdated README.md Outdated
@EvanHahn

This comment has been minimized.

Show comment
Hide comment
@EvanHahn

EvanHahn Jun 4, 2015

Member

Other than my tiny nitpick, this is great and ready to go.

Member

EvanHahn commented Jun 4, 2015

Other than my tiny nitpick, this is great and ready to go.

@eligolding

This comment has been minimized.

Show comment
Hide comment
@eligolding

eligolding Jun 4, 2015

Contributor

Nitpicking is good. I'm still new to this markdown thing. Fixed now.

Contributor

eligolding commented Jun 4, 2015

Nitpicking is good. I'm still new to this markdown thing. Fixed now.

EvanHahn added a commit that referenced this pull request Jun 5, 2015

Merge pull request #4 from eligolding/patch-1
Added warning for lack of browser support for the ALLOW-FROM option

@EvanHahn EvanHahn merged commit 831159c into helmetjs:master Jun 5, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@eligolding

This comment has been minimized.

Show comment
Hide comment
@eligolding

eligolding Jun 5, 2015

Contributor

Thanks!

Contributor

eligolding commented Jun 5, 2015

Thanks!

@EvanHahn

This comment has been minimized.

Show comment
Hide comment
@EvanHahn

EvanHahn Aug 5, 2016

Member

I'm building a list of contributors for a new Helmet.js website. Do you have a name and/or website you want me to use to credit you?

Member

EvanHahn commented Aug 5, 2016

I'm building a list of contributors for a new Helmet.js website. Do you have a name and/or website you want me to use to credit you?

@eligolding

This comment has been minimized.

Show comment
Hide comment
@eligolding

eligolding Aug 5, 2016

Contributor

Thanks! I do not have a personal website, so you can just use my name Eli Golding. If you want you can also attribute www.qualitybath.com. This contribution was made on their time.

Contributor

eligolding commented Aug 5, 2016

Thanks! I do not have a personal website, so you can just use my name Eli Golding. If you want you can also attribute www.qualitybath.com. This contribution was made on their time.

@EvanHahn EvanHahn referenced this pull request Aug 5, 2016

Closed

Add list of contributors #1

@EvanHahn

This comment has been minimized.

Show comment
Hide comment
@EvanHahn

EvanHahn Aug 5, 2016

Member

Added you to the list! Stay tuned for the full website.

Member

EvanHahn commented Aug 5, 2016

Added you to the list! Stay tuned for the full website.

@eligolding

This comment has been minimized.

Show comment
Hide comment
@eligolding

eligolding Aug 5, 2016

Contributor

Thanks! So nice of you to do even for such a small contribution.
Can you use my github profile for my website? Sorry didn't think of that before. Thanks again!

Contributor

eligolding commented Aug 5, 2016

Thanks! So nice of you to do even for such a small contribution.
Can you use my github profile for my website? Sorry didn't think of that before. Thanks again!

@eligolding eligolding deleted the eligolding:patch-1 branch Aug 5, 2016

@EvanHahn

This comment has been minimized.

Show comment
Hide comment
@EvanHahn

EvanHahn Aug 6, 2016

Member

Will do!

Member

EvanHahn commented Aug 6, 2016

Will do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment