New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify default when no arguments passed #9

Merged
merged 1 commit into from Jun 10, 2016

Conversation

Projects
None yet
2 participants
@Limess
Contributor

Limess commented Jun 10, 2016

Updated the README to make it clear from the description's body that SAMEORIGIN is the default option, rather than the currently suggested DENY.

Charlie Briggs
Clarify default when no arguments passed
Updated the README to make it clear from the description's body that `SAMEORIGIN` is the default option, rather than the currently suggested `DENY`.

@EvanHahn EvanHahn merged commit 6950f60 into helmetjs:master Jun 10, 2016

2 checks passed

Node Security No known vulnerabilities found
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@EvanHahn

This comment has been minimized.

Show comment
Hide comment
@EvanHahn

EvanHahn Jun 10, 2016

Member

Thank you—the readme was totally incorrect.

Member

EvanHahn commented Jun 10, 2016

Thank you—the readme was totally incorrect.

@Limess Limess deleted the Limess:patch-1 branch Jun 10, 2016

@EvanHahn

This comment has been minimized.

Show comment
Hide comment
@EvanHahn

EvanHahn Aug 5, 2016

Member

I'm building a list of contributors for a new Helmet.js website. Do you have a name and/or website you want me to use to credit you?

Member

EvanHahn commented Aug 5, 2016

I'm building a list of contributors for a new Helmet.js website. Do you have a name and/or website you want me to use to credit you?

@Limess

This comment has been minimized.

Show comment
Hide comment
@Limess

Limess Aug 5, 2016

Contributor

Oh thanks, can't help but feel it's a bit unjustified for a readme update!
You can use Charlie Briggs and my github profile.

On 5 August 2016 at 20:01, Evan Hahn notifications@github.com wrote:

I'm building a list of contributors for a new Helmet.js website. Do you
have a name and/or website you want me to use to credit you?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#9 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADDQzWz-jYHc0H-vLk4Mv3cE9I-zQEezks5qc4ibgaJpZM4Iy2Ds
.

Contributor

Limess commented Aug 5, 2016

Oh thanks, can't help but feel it's a bit unjustified for a readme update!
You can use Charlie Briggs and my github profile.

On 5 August 2016 at 20:01, Evan Hahn notifications@github.com wrote:

I'm building a list of contributors for a new Helmet.js website. Do you
have a name and/or website you want me to use to credit you?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#9 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADDQzWz-jYHc0H-vLk4Mv3cE9I-zQEezks5qc4ibgaJpZM4Iy2Ds
.

@EvanHahn

This comment has been minimized.

Show comment
Hide comment
@EvanHahn

EvanHahn Aug 5, 2016

Member

No change is to small! I'll add you to the contributors list.

Member

EvanHahn commented Aug 5, 2016

No change is to small! I'll add you to the contributors list.

@EvanHahn EvanHahn referenced this pull request Aug 5, 2016

Closed

Add list of contributors #1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment