New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if a helmet constructor is used directly as handler #152

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@Qix-
Contributor

Qix- commented Jun 5, 2017

Not sure if this is something you'd consider helpful, but I just did app.use(helmet) by itself and was confused for a minute why my requests were timing out. More of a friendly reminder of usage.

Should be fully backwards compatible and not affect anyone using Helmet properly.

@EvanHahn

This comment has been minimized.

Show comment
Hide comment
@EvanHahn

EvanHahn Jun 5, 2017

Member

This looks like a good change. I'll merge it when I get the chance (on my phone presently).

In the meantime, would you add yourself as a contributor on helmetjs.github.io? Happy to write instructions when I'm back at a desk.

Member

EvanHahn commented Jun 5, 2017

This looks like a good change. I'll merge it when I get the chance (on my phone presently).

In the meantime, would you add yourself as a contributor on helmetjs.github.io? Happy to write instructions when I'm back at a desk.

@Qix-

This comment has been minimized.

Show comment
Hide comment
@Qix-

Qix- Jun 5, 2017

Contributor

Sure, done :)

Contributor

Qix- commented Jun 5, 2017

Sure, done :)

@EvanHahn

This comment has been minimized.

Show comment
Hide comment
@EvanHahn

EvanHahn Jun 6, 2017

Member

I added a test, changed the error message, and merged manually in e213d87. This will go out in the next release of Helmet.

Thanks for your contribution!

Member

EvanHahn commented Jun 6, 2017

I added a test, changed the error message, and merged manually in e213d87. This will go out in the next release of Helmet.

Thanks for your contribution!

@EvanHahn EvanHahn closed this Jun 6, 2017

EvanHahn pushed a commit to helmetjs/helmetjs.github.io that referenced this pull request Jun 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment