New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hsts test #25

Merged
merged 7 commits into from Dec 10, 2013

Conversation

Projects
None yet
2 participants
@mattjay
Contributor

mattjay commented Dec 4, 2013

HSTS Tests

  • Working HSTS File using setHeader
  • Passing HSTS tests for both default and with args
@EvanHahn

This comment has been minimized.

Show comment
Hide comment
@EvanHahn

EvanHahn Dec 4, 2013

Member

Looks good -- please run JSHint on test/hsts.js, fix those minor indentation issues, and I'll merge.

This doesn't fully resolve #24 -- req.secure is Express-only (run this to test it) -- but it certainly helps!

Member

EvanHahn commented Dec 4, 2013

Looks good -- please run JSHint on test/hsts.js, fix those minor indentation issues, and I'll merge.

This doesn't fully resolve #24 -- req.secure is Express-only (run this to test it) -- but it certainly helps!

@mattjay

This comment has been minimized.

Show comment
Hide comment
@mattjay

mattjay Dec 4, 2013

Contributor

Don't see any indentation issues getting flagged by JSHint but did yell at me for not including "use strict";
I use indentation 2 in my IDE though, would you like me to switch to 4?

Contributor

mattjay commented Dec 4, 2013

Don't see any indentation issues getting flagged by JSHint but did yell at me for not including "use strict";
I use indentation 2 in my IDE though, would you like me to switch to 4?

@mattjay

This comment has been minimized.

Show comment
Hide comment
@mattjay

mattjay Dec 4, 2013

Contributor

@EvanHahn I also see what you're saying about req.secure now. How can I go about testing both in the same file? I guess I could manually build a mock req object and just have a secure property defined for a 3rd it block.

Contributor

mattjay commented Dec 4, 2013

@EvanHahn I also see what you're saying about req.secure now. How can I go about testing both in the same file? I guess I could manually build a mock req object and just have a secure property defined for a 3rd it block.

@EvanHahn

This comment has been minimized.

Show comment
Hide comment
@EvanHahn

EvanHahn Dec 4, 2013

Member

Yes, switch to 4 spaces. Is it not picking up the jshintrc?

I think we'll probably wind up changing HSTS to be Connect-compatible. I'd leave the tests as they are now, but we'll add more that test Connect-only functionality.

Member

EvanHahn commented Dec 4, 2013

Yes, switch to 4 spaces. Is it not picking up the jshintrc?

I think we'll probably wind up changing HSTS to be Connect-compatible. I'd leave the tests as they are now, but we'll add more that test Connect-only functionality.

@mattjay

This comment has been minimized.

Show comment
Hide comment
@mattjay

mattjay Dec 10, 2013

Contributor

@EvanHahn let me know if you need me to do anything else here.

Contributor

mattjay commented Dec 10, 2013

@EvanHahn let me know if you need me to do anything else here.

EvanHahn added a commit that referenced this pull request Dec 10, 2013

@EvanHahn EvanHahn merged commit 26daeda into helmetjs:master Dec 10, 2013

@EvanHahn

This comment has been minimized.

Show comment
Hide comment
@EvanHahn

EvanHahn Dec 10, 2013

Member

@mattjay Sorry I missed this -- don't think I got a notification. Thanks so much!

Member

EvanHahn commented Dec 10, 2013

@mattjay Sorry I missed this -- don't think I got a notification. Thanks so much!

@mattjay

This comment has been minimized.

Show comment
Hide comment
@mattjay

mattjay Dec 10, 2013

Contributor

👍 👍 👍 Glad to help.

Contributor

mattjay commented Dec 10, 2013

👍 👍 👍 Glad to help.

@mattjay mattjay deleted the mattjay:hsts_test branch Dec 11, 2013

@EvanHahn

This comment has been minimized.

Show comment
Hide comment
@EvanHahn

EvanHahn Aug 5, 2016

Member

@mattjay I'm making a new website for Helmet.js and I want to credit everyone who's contributed. Do you have a name and/or website you'd like me to use to credit you?

Member

EvanHahn commented Aug 5, 2016

@mattjay I'm making a new website for Helmet.js and I want to credit everyone who's contributed. Do you have a name and/or website you'd like me to use to credit you?

@mattjay

This comment has been minimized.

Show comment
Hide comment
@mattjay

mattjay Aug 5, 2016

Contributor

@EvanHahn Matt Johansen - @mattjay on twitter works. Website - mattjay.github.io

Thanks

Contributor

mattjay commented Aug 5, 2016

@EvanHahn Matt Johansen - @mattjay on twitter works. Website - mattjay.github.io

Thanks

@EvanHahn

This comment has been minimized.

Show comment
Hide comment
@EvanHahn

EvanHahn Aug 6, 2016

Member
Member

EvanHahn commented Aug 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment