New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support helmet.defaults() as middleware, fixes #13 #29

Merged
merged 2 commits into from Mar 28, 2014

Conversation

Projects
None yet
2 participants
@natevw
Contributor

natevw commented Jan 28, 2014

Here's a simple way to support both the old and more conventional middleware-like usage of helmet.defaults().

NOTE: there's one caveat in that the user must be using (i.e. have installed) either 'express' or 'connect' themselves but that seemed a reasonable enough assumption, eh?

Support helmet.defaults() as middleware, fixes #13
Here's a simple way to support both the old and more conventional middleware-like usage of `helmet.defaults()`.

NOTE: there's one caveat in that the user *must* be using (i.e. have installed) either 'express' or 'connect' themselves but that seemed a reasonable enough assumption, eh?

EvanHahn added a commit that referenced this pull request Mar 28, 2014

Merge pull request #29 from natevw/patch-1
Support helmet.defaults() as middleware, fixes #13

@EvanHahn EvanHahn merged commit 75133b3 into helmetjs:master Mar 28, 2014

@EvanHahn

This comment has been minimized.

Show comment
Hide comment
@EvanHahn

EvanHahn Mar 28, 2014

Member

Looks good. Thanks!

Member

EvanHahn commented Mar 28, 2014

Looks good. Thanks!

@EvanHahn

This comment has been minimized.

Show comment
Hide comment
@EvanHahn

EvanHahn Aug 5, 2016

Member

@natevw I'm making a new website for Helmet.js and I want to credit everyone who's contributed. Do you have a name and/or website you'd like me to use to credit you?

Member

EvanHahn commented Aug 5, 2016

@natevw I'm making a new website for Helmet.js and I want to credit everyone who's contributed. Do you have a name and/or website you'd like me to use to credit you?

@natevw

This comment has been minimized.

Show comment
Hide comment
@natevw

natevw Aug 5, 2016

Contributor

@EvanHahn Sure, you can use either "Nathan Vander Wilt" or "natevw" and my homepage is http://exts.ch — appreciate it!

Contributor

natevw commented Aug 5, 2016

@EvanHahn Sure, you can use either "Nathan Vander Wilt" or "natevw" and my homepage is http://exts.ch — appreciate it!

@EvanHahn EvanHahn referenced this pull request Aug 5, 2016

Closed

Add list of contributors #1

@EvanHahn

This comment has been minimized.

Show comment
Hide comment
@EvanHahn

EvanHahn Aug 5, 2016

Member

Thanks! Added you to the list.

Member

EvanHahn commented Aug 5, 2016

Thanks! Added you to the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment