New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using _ functions wherever applicable #62

Merged
merged 2 commits into from Jul 8, 2014

Conversation

Projects
None yet
2 participants
@thefourtheye
Contributor

thefourtheye commented Jul 5, 2014

Using _ functions and strict equal comparison operators

Using _ functions wherever applicable
Using _ functions and strict equal comparison operators
@EvanHahn

This comment has been minimized.

Show comment
Hide comment
@EvanHahn

EvanHahn Jul 7, 2014

Member

Looks good. Could you change the quotes to appease JSHint, though?

// from this:
var _ = require("underscore");
// to this:
var _ = require('underscore');

Looks good other than that!

Member

EvanHahn commented Jul 7, 2014

Looks good. Could you change the quotes to appease JSHint, though?

// from this:
var _ = require("underscore");
// to this:
var _ = require('underscore');

Looks good other than that!

@thefourtheye

This comment has been minimized.

Show comment
Hide comment
@thefourtheye

thefourtheye Jul 8, 2014

Contributor

@EvanHahn Done :) Please check now, also I have submitted another pull request #61. You might want to review that as well :)

Contributor

thefourtheye commented Jul 8, 2014

@EvanHahn Done :) Please check now, also I have submitted another pull request #61. You might want to review that as well :)

EvanHahn added a commit that referenced this pull request Jul 8, 2014

Merge pull request #62 from thefourtheye/patch-2
Using _ functions wherever applicable

@EvanHahn EvanHahn merged commit 699d1a4 into helmetjs:master Jul 8, 2014

@EvanHahn

This comment has been minimized.

Show comment
Hide comment
@EvanHahn

EvanHahn Jul 8, 2014

Member

Thanks!

Member

EvanHahn commented Jul 8, 2014

Thanks!

@thefourtheye thefourtheye deleted the thefourtheye:patch-2 branch Jul 8, 2014

@EvanHahn

This comment has been minimized.

Show comment
Hide comment
@EvanHahn

EvanHahn Aug 5, 2016

Member

@thefourtheye I'm making a new website for Helmet.js and I want to credit everyone who's contributed. Do you have a name and/or website you'd like me to use to credit you?

Member

EvanHahn commented Aug 5, 2016

@thefourtheye I'm making a new website for Helmet.js and I want to credit everyone who's contributed. Do you have a name and/or website you'd like me to use to credit you?

@EvanHahn EvanHahn referenced this pull request Aug 5, 2016

Closed

Add list of contributors #1

@thefourtheye

This comment has been minimized.

Show comment
Hide comment
@thefourtheye

thefourtheye Aug 8, 2016

Contributor

@EvanHahn Thank you :-) My name is "Sakthipriyan Vairamani (thefourtheye)". Website: http://thefourtheye.in/.

Contributor

thefourtheye commented Aug 8, 2016

@EvanHahn Thank you :-) My name is "Sakthipriyan Vairamani (thefourtheye)". Website: http://thefourtheye.in/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment