New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a condition to set the header #9

Merged
merged 1 commit into from Mar 2, 2016

Conversation

Projects
None yet
2 participants
@exeto
Contributor

exeto commented Feb 26, 2016

No description provided.

@@ -20,8 +20,13 @@ app.use(hpkp({
maxAge: ninetyDaysInMilliseconds,
sha256s: ['AbCdEf123=', 'ZyXwVu456='],
includeSubdomains: true, // optional
reportUri: 'http://example.com' // optional
reportOnly: false // optional
reportUri: 'http://example.com', // optional

This comment has been minimized.

@EvanHahn

EvanHahn Feb 27, 2016

Member

Good catch here!

@EvanHahn

EvanHahn Feb 27, 2016

Member

Good catch here!

Show outdated Hide outdated index.js Outdated
@EvanHahn

This comment has been minimized.

Show comment
Hide comment
@EvanHahn

EvanHahn Feb 27, 2016

Member

I like this! Could you add tests and I'll merge?

Member

EvanHahn commented Feb 27, 2016

I like this! Could you add tests and I'll merge?

@exeto

This comment has been minimized.

Show comment
Hide comment
@exeto

exeto Feb 28, 2016

Contributor

@EvanHahn done.

Contributor

exeto commented Feb 28, 2016

@EvanHahn done.

@EvanHahn

This comment has been minimized.

Show comment
Hide comment
@EvanHahn

EvanHahn Feb 28, 2016

Member

Perfect! Thanks so much.

If you'd like to add yourself in the contributors part of package.json, feel free. I'll merge and release hpkp@1.1.0 tomorrow!

Member

EvanHahn commented Feb 28, 2016

Perfect! Thanks so much.

If you'd like to add yourself in the contributors part of package.json, feel free. I'll merge and release hpkp@1.1.0 tomorrow!

EvanHahn added a commit that referenced this pull request Mar 2, 2016

Merge pull request #9 from exeto/patch-1
Add a condition to set the header

@EvanHahn EvanHahn merged commit e19b584 into helmetjs:master Mar 2, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@EvanHahn

This comment has been minimized.

Show comment
Hide comment
@EvanHahn

EvanHahn Mar 2, 2016

Member

This is released in hpkp@1.1.0 and helmet@1.3.0. Thanks!

Member

EvanHahn commented Mar 2, 2016

This is released in hpkp@1.1.0 and helmet@1.3.0. Thanks!

@exeto

This comment has been minimized.

Show comment
Hide comment
@exeto

exeto Mar 2, 2016

Contributor

Thanks

Contributor

exeto commented Mar 2, 2016

Thanks

@EvanHahn

This comment has been minimized.

Show comment
Hide comment
@EvanHahn

EvanHahn Aug 5, 2016

Member

I'm building a list of contributors for a new Helmet.js website. Do you have a name and/or website you want me to use to credit you?

Member

EvanHahn commented Aug 5, 2016

I'm building a list of contributors for a new Helmet.js website. Do you have a name and/or website you want me to use to credit you?

@exeto

This comment has been minimized.

Show comment
Hide comment
@exeto

exeto Aug 5, 2016

Contributor

Timofey Dergachev, https://exeto.me/en

Contributor

exeto commented Aug 5, 2016

Timofey Dergachev, https://exeto.me/en

@EvanHahn EvanHahn referenced this pull request Aug 5, 2016

Closed

Add list of contributors #1

@EvanHahn

This comment has been minimized.

Show comment
Hide comment
@EvanHahn

EvanHahn Aug 5, 2016

Member

Thanks! Added you to the list—stay tuned for the full website.

Member

EvanHahn commented Aug 5, 2016

Thanks! Added you to the list—stay tuned for the full website.

@exeto

This comment has been minimized.

Show comment
Hide comment
@exeto

exeto Aug 5, 2016

Contributor

Thanks

Contributor

exeto commented Aug 5, 2016

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment