New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Surrogate-Control header #5

Merged
merged 1 commit into from Oct 28, 2015

Conversation

Projects
None yet
2 participants
@analog-nico
Contributor

analog-nico commented Oct 23, 2015

Shared caches like CDNs are respecting Surrogate headers (Spec) for deciding how to cache resources. At least for fastly.com the Surrogate-Control takes precedence over all other headers. In this case, though, Fastly would check the Expires header afterwards which is set by this library so the Surrogate-Control header wouldn't be necessary. Since I can't speak for all the other shared caches out there I think adding this header makes the library more robust.

EvanHahn added a commit that referenced this pull request Oct 28, 2015

Merge pull request #5 from analog-nico/master
Added Surrogate-Control header

@EvanHahn EvanHahn merged commit 96f2c29 into helmetjs:master Oct 28, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@EvanHahn

This comment has been minimized.

Show comment
Hide comment
@EvanHahn

EvanHahn Oct 28, 2015

Member

Looks great! I'll release new versions of this and of Helmet tomorrow.

Member

EvanHahn commented Oct 28, 2015

Looks great! I'll release new versions of this and of Helmet tomorrow.

@analog-nico

This comment has been minimized.

Show comment
Hide comment
@analog-nico

analog-nico Oct 28, 2015

Contributor

Thanks Evan!

Contributor

analog-nico commented Oct 28, 2015

Thanks Evan!

@EvanHahn

This comment has been minimized.

Show comment
Hide comment
@EvanHahn

EvanHahn Nov 1, 2015

Member

@analog-nico Sorry this took more than a day—I just released nocache@0.4.0 and helmet@0.14.0. Thanks again!

Member

EvanHahn commented Nov 1, 2015

@analog-nico Sorry this took more than a day—I just released nocache@0.4.0 and helmet@0.14.0. Thanks again!

@analog-nico

This comment has been minimized.

Show comment
Hide comment
@analog-nico

analog-nico Nov 1, 2015

Contributor

No problem. Have a good one!

Contributor

analog-nico commented Nov 1, 2015

No problem. Have a good one!

@EvanHahn

This comment has been minimized.

Show comment
Hide comment
@EvanHahn

EvanHahn Jul 31, 2016

Member

@analog-nico I'm planning on starting a list of contributors (probably just a big list of bullet points) and I'd like to put you on the list. How should I credit you?

Member

EvanHahn commented Jul 31, 2016

@analog-nico I'm planning on starting a list of contributors (probably just a big list of bullet points) and I'd like to put you on the list. How should I credit you?

@analog-nico

This comment has been minimized.

Show comment
Hide comment
@analog-nico

analog-nico Jul 31, 2016

Contributor

Ooh, thank you!

I usually put "Nicolai Kamenzky (https://github.com/analog-nico)" into the package.json. Feel free to choose any of my full name, my Github handle, and my Github profile.

Contributor

analog-nico commented Jul 31, 2016

Ooh, thank you!

I usually put "Nicolai Kamenzky (https://github.com/analog-nico)" into the package.json. Feel free to choose any of my full name, my Github handle, and my Github profile.

@EvanHahn EvanHahn referenced this pull request Aug 5, 2016

Closed

Add list of contributors #1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment