Allow to override build date with SOURCE_DATE_EPOCH #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmwiedemann
requested review from
mumoshu,
itscaro and
yxxhero
as code owners
|
@bmwiedemann please fix DCO issue. |
|
added |
in order to make builds reproducible. See https://reproducible-builds.org/ for why this is good and https://reproducible-builds.org/specs/source-date-epoch/ for the definition of this variable. This date call works with different variants of date. Also use UTC to be independent of timezone. Signed-off-by: Bernhard M. Wiedemann <bwiedemann@suse.de>
|
@bmwiedemann do you test it locally? |
|
Yes, I tested it. |
|
@bmwiedemann Thanks for your feedback. I have a question. Can |
It can be set by any caller of |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Allow to override build date with
SOURCE_DATE_EPOCHin order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good and https://reproducible-builds.org/specs/source-date-epoch/ for the definition of this variable.
This date call works with different variants of date.
Also use UTC to be independent of timezone.