This repository has been archived by the owner on Aug 21, 2023. It is now read-only.
FluffyCard + OptionTile components #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
September 14, 2018 16:39
This update creates the new FluffyCard component (along with a Container). This component uses the base `Card` component, which has been refactored with the latest Blue conventions. This needs to be E2E tested, as Card will no longer render styles using SCSS.
Setup ThemeProvider support for OptionIcon. Add stories for both components.
|
Thanks @Charca ! 🤗 |
|
Thanks all! Merging and make a minor release! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FluffyCard + OptionTile components
This update adds a couple of new components, notably
FluffyCardandOptionTile.The base
Cardcomponent was refactored with modern Blue standards, as well asCSS-in-JS styling.
I did a beta test build with
Cardwithin Embed (to double check), and everything workedfine.
OptionTile(specificallyOptionIcon) is the first Blue component setup to use CSS-in-JSbased theming, defined by a
ThemeProvider. This will make it easier to implement into auser-themable environment like Embed.
Stories, docs, and tests for added for all the new components.
Interactions and styles based on @digitaldesigner 's Codepen:
https://codepen.io/buzzusborne/full/982b39329647ad92088b496705a74c78/
How to test
npm startExample
The component API for these guys should be relatively simple as well!