Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add methods to reduce necessary null checks #75

Closed
davidstanley01 opened this issue Dec 19, 2018 · 1 comment · Fixed by #230
Closed

Add methods to reduce necessary null checks #75

davidstanley01 opened this issue Dec 19, 2018 · 1 comment · Fixed by #230

Comments

@davidstanley01
Copy link
Contributor

Across the entities such as Conversation, Thread we should add methods like $conversation->isAssigned() rather than having to do $conversation->getAssigned() === null.

There's a lot of perks here:

  • keeps our customer's code cleaner and easier to read, reducing possible errors they'll encounter
  • makes the way our application works easier for developers to understand
  • boosts developer confidence
  • enables us to reduce the number of methods that return mixed values
@davidstanley01
Copy link
Contributor Author

Partially addressed in #82. I'm going to take another look at things before closing this out as complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant