Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation update entities any collection #126

merged 5 commits into from Apr 9, 2019


None yet
2 participants
Copy link

commented Apr 9, 2019

$client->conversations()->updateTags($conversation, $tags); and $client->conversations()->updateCustomFields($conversation, $customFields); both were strongly typed to accept an array of tags/fields. This actually creates some challenges because when fetching a conversation the tags come back in a Collection and adding tags uses a TagCollection due to the response/request body format.

This PR updates both update methods to accept various collections so the SDK is a bit more flexible and developers don't have to worry about which collection they're passing to the update methods.

bkuhl added some commits Apr 9, 2019

@bkuhl bkuhl requested a review from ShayCichocki Apr 9, 2019

Copy link

left a comment

Seems reasonable to me!

@bkuhl bkuhl merged commit 06e3a3d into master Apr 9, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed

@bkuhl bkuhl deleted the conversation-update-entities-any-collection branch Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.