Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating subentities with customers #144

Merged
merged 9 commits into from May 9, 2019

Conversation

Projects
None yet
2 participants
@bkuhl
Copy link
Contributor

commented May 7, 2019

This is an expansion on the work begun in #142.

Problem

The underlying issue is that we built Customer support first, then went through and built support for its sub-entities such as Website, CustomField, etc. and overlooked ensuring those were extracted with the Customer itself. This meant that these extra details could not be attached to the initial Customer when it was being created.

Solution

With this branch these sub-entities are now extracted alongside the Customer, allowing them to be attached to the Customer during initial creation.

bkuhl added some commits May 7, 2019

@bkuhl bkuhl requested a review from tompedals May 7, 2019

bkuhl added some commits May 7, 2019

use ExtractsData;
use HasPartiesToBeNotified;
use IncludesThreadDetails;
use HasCustomer;

This comment has been minimized.

Copy link
@bkuhl

bkuhl May 7, 2019

Author Contributor

Got a bunch of complaints by CI on this kind of thing... not sure why it's suddenly caring about these and wasn't before...

This comment has been minimized.

Copy link
@tompedals

tompedals May 9, 2019

Contributor

I think it might be the Symfony PHP CS Fixer ruleset may have changed? https://github.com/helpscout/helpscout-api-php/blob/master/.php_cs. Perhaps we've updated the dependencies recently? If we want to allow it we can adjust the ruleset in that config file like we did for some others, yoda style for example.

This comment has been minimized.

Copy link
@bkuhl

bkuhl May 9, 2019

Author Contributor

On that note, I blew away my vendor directory and was suddenly seeing this issue locally. I've added 'single_trait_insert_per_statement' => false, and reverted all the use usages I added so we're back to multiple traits per use statement.

@tompedals
Copy link
Contributor

left a comment

Looks great 🚢

use ExtractsData;
use HasPartiesToBeNotified;
use IncludesThreadDetails;
use HasCustomer;

This comment has been minimized.

Copy link
@tompedals

tompedals May 9, 2019

Contributor

I think it might be the Symfony PHP CS Fixer ruleset may have changed? https://github.com/helpscout/helpscout-api-php/blob/master/.php_cs. Perhaps we've updated the dependencies recently? If we want to allow it we can adjust the ruleset in that config file like we did for some others, yoda style for example.

@bkuhl bkuhl merged commit 473b839 into master May 9, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@bkuhl bkuhl deleted the creating-subentities-with-customers branch May 9, 2019

@bkuhl bkuhl referenced this pull request May 9, 2019

Closed

Fixed Customer extract #142

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.