Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User agent now provides php version and SDK version numbers #145

Merged
merged 2 commits into from May 9, 2019

Conversation

Projects
None yet
2 participants
@bkuhl
Copy link
Contributor

commented May 7, 2019

Resolves #143.

Great catch on this issue @tompedals! This also highlights that I haven't been incrementing our ApiClient version number as we've been releasing it.

@bkuhl bkuhl requested a review from tompedals May 7, 2019

@bkuhl

This comment has been minimized.

Copy link
Contributor Author

commented May 7, 2019

There's some phpcs failures happening here, but they're fixed in #145 so merging that in here should fix it.

@tompedals
Copy link
Contributor

left a comment

Looks good, thanks for picking this up. It will help us track usage of the client 👍

@bkuhl bkuhl merged commit 9c1b679 into master May 9, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@bkuhl bkuhl deleted the 143-client-header branch May 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.