Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type to thread response #159

Merged
merged 3 commits into from Jun 5, 2019

Conversation

Projects
None yet
2 participants
@wking-io
Copy link
Contributor

commented Jun 5, 2019

The thread response was missing the 'type' property. We saw that you manage thread types with a number of extended thread classes, but noticed that on request the client just defaults to using the Thread class. So instead of working through how to conditionally assign the specific extended class depending on the type in the response we went with just adding the type property to the base Thread class.

@wking-io

This comment has been minimized.

Copy link
Contributor Author

commented Jun 5, 2019

Fixes #156

@bkuhl

bkuhl approved these changes Jun 5, 2019

Copy link
Contributor

left a comment

We do have a ThreadFactory I'd like to use when building collections, but we use Thread as a fallback if there's not a matching class for the thread type so we still need this. Thanks for the contribution

@bkuhl bkuhl merged commit 8a13f7e into helpscout:master Jun 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.