Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw an AuthenticationException for 401 status codes #212

Merged
merged 9 commits into from Jan 2, 2020
Merged

Conversation

@anthonyterrell
Copy link
Contributor

anthonyterrell commented Dec 11, 2019

Closes #153

⚠️ This should be merged in before #214 to prevent merge conflicts

This PR uses the existing AuthenticationException when the status code 401 is returned.

@anthonyterrell anthonyterrell changed the base branch from master to v2 Dec 11, 2019
@anthonyterrell anthonyterrell force-pushed the update-http-exceptions branch from 8814f2f to 7ee7f13 Dec 11, 2019
@anthonyterrell anthonyterrell requested a review from bkuhl Dec 11, 2019
@anthonyterrell anthonyterrell changed the title WIP: Throw an AuthenticationException for 401 status codes Throw an AuthenticationException for 401 status codes Dec 11, 2019
@bkuhl bkuhl changed the base branch from v2 to master Dec 11, 2019
Copy link
Contributor

bkuhl left a comment

Looks great, just 2 minor things

src/Http/Handlers/ClientErrorHandler.php Show resolved Hide resolved
src/Http/Handlers/AuthenticationHandler.php Outdated Show resolved Hide resolved
@anthonyterrell anthonyterrell requested a review from bkuhl Dec 12, 2019
Anthony Terrell added 2 commits Dec 30, 2019
Anthony Terrell Anthony Terrell
Anthony Terrell Anthony Terrell
@anthonyterrell anthonyterrell changed the base branch from master to v2 Dec 30, 2019
@bkuhl
bkuhl approved these changes Jan 2, 2020
@bkuhl bkuhl merged commit e98660c into v2 Jan 2, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@bkuhl bkuhl deleted the update-http-exceptions branch Jan 2, 2020
@bkuhl bkuhl restored the update-http-exceptions branch Jan 2, 2020
@bkuhl bkuhl deleted the update-http-exceptions branch Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.