Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require PHP 7.3 and upgrade PHPUnit 8 #214

Merged
merged 8 commits into from Jan 2, 2020
Merged

Require PHP 7.3 and upgrade PHPUnit 8 #214

merged 8 commits into from Jan 2, 2020

Conversation

@anthonyterrell
Copy link
Contributor

anthonyterrell commented Dec 30, 2019

⚠️ This should be merged in after #212 to prevent merge conflicts

This pull request does a couple things:

  1. Requires PHP7.3 as 7.2 will only be receiving security updates for the majority of 2020.
  2. Upgrades PHPUnit to version 8

The assertArraySubset() test method has been deprecated, with no suggested alternative. Luckily there was only a single use that I replaced with 11 explicit assertions.

Once this is merged, the phpunit-8 branch/tree can be deleted.

@@ -248,7 +248,9 @@ public function testExtract()
);
$conversation->setCustomerWaitingSince($customerWaitingSince);

$this->assertArraySubset([

This comment has been minimized.

Copy link
@anthonyterrell

anthonyterrell Dec 30, 2019

Author Contributor

Unfortunately this method has been deprecated so I explicitly tested first and second level array values in the extracted conversation.

Normally I would chunk this up into separate tests entirely to move away from a single long test, but wanted to keep changes to a minimum for now.

@bkuhl
bkuhl approved these changes Jan 2, 2020
Copy link
Contributor

bkuhl left a comment

Looks great, nice work!

@bkuhl bkuhl merged commit fd8c9d7 into v2 Jan 2, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@bkuhl bkuhl deleted the require-php-73 branch Jan 2, 2020
@bkuhl bkuhl restored the require-php-73 branch Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.