Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ConversationFilter object methods for clarity #224

Merged
merged 6 commits into from Jan 6, 2020

Conversation

@anthonyterrell
Copy link
Contributor

anthonyterrell commented Jan 6, 2020

Relates to #208

To reduce confusion when using a ConversationFilters object some methods have been changed. This is a breaking change targeting version 3. All usages and tests have been updated.

Changes

  1. withMailbox => inMailbox
  2. withStatus => inStatus
  3. withFolder => inFolder
  4. withTag => hasTag
  5. withTags => hasTags
  6. withAssignedTo => assignedTo
  7. withModifiedSince => modifiedSince
  8. withNumber => byNumber
  9. withSortField => sortField
  10. withSortOrder => sortOrder
@anthonyterrell anthonyterrell force-pushed the rename-filter-object-methods-for-clarity branch from efa03de to ba72b0a Jan 6, 2020
@anthonyterrell anthonyterrell changed the title WIP: Rename filter object methods for clarity ConversationFilter object methods for clarity Jan 6, 2020
@anthonyterrell anthonyterrell changed the title ConversationFilter object methods for clarity Rename ConversationFilter object methods for clarity Jan 6, 2020
@anthonyterrell anthonyterrell requested a review from bkuhl Jan 6, 2020
@anthonyterrell anthonyterrell changed the title Rename ConversationFilter object methods for clarity WIP: Rename ConversationFilter object methods for clarity Jan 6, 2020
@anthonyterrell anthonyterrell changed the title WIP: Rename ConversationFilter object methods for clarity Rename ConversationFilter object methods for clarity Jan 6, 2020
@bkuhl
bkuhl approved these changes Jan 6, 2020
Copy link
Contributor

bkuhl left a comment

Looks good!

@bkuhl bkuhl merged commit e9a2a5e into master Jan 6, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@bkuhl bkuhl deleted the rename-filter-object-methods-for-clarity branch Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.