Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename UserFilter object methods #225

Merged
merged 3 commits into from Jan 6, 2020
Merged

Conversation

@anthonyterrell
Copy link
Contributor

anthonyterrell commented Jan 6, 2020

Relates to #208

To reduce confusion when using a UserFilter object some methods have been changed. This is a breaking change targeting version 3. All usages and tests have been updated.

Changes

  1. withEmail => byEmail
  2. withMailbox => inMailbox

To be merged in after #224

Anthony Terrell added 2 commits Jan 6, 2020
Anthony Terrell Anthony Terrell
…rename-user-filter-object-methods
@anthonyterrell anthonyterrell changed the title WIP: Rename UserFilter object methods Rename UserFilter object methods Jan 6, 2020
@anthonyterrell anthonyterrell requested a review from bkuhl Jan 6, 2020
@bkuhl
bkuhl approved these changes Jan 6, 2020
Copy link
Contributor

bkuhl left a comment

Nice

@bkuhl bkuhl merged commit eaac8e2 into master Jan 6, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@bkuhl bkuhl deleted the rename-user-filter-object-methods branch Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.