Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename CustomerFilter object methods for clarity #226

Merged
merged 2 commits into from Jan 6, 2020

Conversation

@anthonyterrell
Copy link
Contributor

anthonyterrell commented Jan 6, 2020

Relates to #208

To reduce confusion when using a CustomerFilter object some methods have been changed. This is a breaking change targeting version 3. All usages and tests have been updated.

Changes

  1. withFirstName => byFirstName
  2. withLastName => byLastName
  3. withMailbox => inMailbox
  4. withModifiedSince => modifiedSince
  5. withSortField => sortField
  6. withSortOrder => sortOrder

To be merged in after #224

@anthonyterrell anthonyterrell force-pushed the rename-customer-filter-object-methods-for-clarity branch from c81ccb7 to 706428c Jan 6, 2020
…rename-customer-filter-object-methods-for-clarity
@anthonyterrell anthonyterrell requested a review from bkuhl Jan 6, 2020
@anthonyterrell anthonyterrell changed the title WIP: Rename CustomerFilter object methods for clarity Rename CustomerFilter object methods for clarity Jan 6, 2020
@bkuhl
bkuhl approved these changes Jan 6, 2020
@bkuhl bkuhl merged commit 65b1766 into master Jan 6, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@bkuhl bkuhl deleted the rename-customer-filter-object-methods-for-clarity branch Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.