Skip to content
This repository has been archived by the owner on Aug 21, 2023. It is now read-only.

Move scrollbar on Message Card body a bit off from the right edge #941

Merged
merged 1 commit into from Jun 21, 2021

Conversation

jakubjanczyk
Copy link
Collaborator

Problem/Feature

Scrollabar on MessageCard body is a bit too close to the right edge of the whole Card. This moves it by to 2px to the left side, so there's more space. The scrollbars might be different depending on the browser and/or operating system.

Related JIRA issue: https://helpscout.atlassian.net/browse/BEMBED-281

There is a Story added that present MessageCard with a scrollbar - MessageCard -> with body scrollbar

Before:
Screenshot from 2021-06-10 17-05-13

After:
Screenshot from 2021-06-10 17-17-09

Guidelines

Make sure the pull request:

  • Follows the established folder/file structure
  • Adds unit tests
  • Did you verify some accessibility (a11y) basics?
  • Adds/updates stories. Guidelines
  • Adds/updates documentation (ie proptypes) Guidelines
  • Has it been tested in Help Scout's supported browsers?
  • Requests review from designer of the feature
  • Add label (bug? feature?)

@jakubjanczyk
Copy link
Collaborator Author

@alexestrada could you take a look if that solves the issue on Message preview? Thanks!

@netlify
Copy link

netlify bot commented Jun 10, 2021

✔️ Deploy Preview for hsds-react ready!

🔨 Explore the source changes: 6bfe074

🔍 Inspect the deploy log: https://app.netlify.com/sites/hsds-react/deploys/60c22da4e3d63c000719acb8

😎 Browse the preview: https://deploy-preview-941--hsds-react.netlify.app/iframe

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3616

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.768%

Totals Coverage Status
Change from base Build 3615: 0.0%
Covered Lines: 6584
Relevant Lines: 6846

💛 - Coveralls

Copy link

@alexestrada alexestrada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed screenshots since I can't access HSDS previews. Looks good, thank you for getting to this one! 🙏

Copy link
Collaborator

@tinkertrain tinkertrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@jakubjanczyk jakubjanczyk merged commit 3b66b3a into master Jun 21, 2021
@jakubjanczyk jakubjanczyk deleted the message-card-scrollbar branch June 21, 2021 11:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants