Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the required league/oauth2-client version #2

Merged
merged 11 commits into from Jan 9, 2020

Conversation

@tompedals
Copy link
Contributor

tompedals commented Jan 2, 2020

We need to support the newer versions of the required packages so that we are using those tested on newer versions of PHP. I have also updated our Travis config so that we test on newer versions of PHP.

tompedals added 3 commits Jan 2, 2020
@tompedals tompedals requested a review from bkuhl Jan 7, 2020
@bkuhl
bkuhl approved these changes Jan 7, 2020
Copy link

bkuhl left a comment

I'm including one suggestion to include we run tests against php7.4 as well, but it looks good!

- hhvm
- 7.1
- 7.2
- 7.3

This comment has been minimized.

Copy link
@bkuhl

bkuhl Jan 7, 2020

PHP 7.4 is officially released so I think we should be able to support it here as well.

Suggested change
- 7.3
- 7.3
- 7.4
@@ -17,7 +17,7 @@
"hubspot"
],
"require": {
"league/oauth2-client": "^1.0"
"league/oauth2-client": "^2.0"

This comment has been minimized.

Copy link
@bkuhl

bkuhl Jan 7, 2020

What version is this release targeting? Looks like it's at 0.1.1. I think we should perhaps target v1.0 since a dependency is now requiring a major bump.

This comment has been minimized.

Copy link
@tompedals

tompedals Jan 7, 2020

Author Contributor

Yep, I was going to bump to v1.0 when releasing with this change 👍

tompedals added 8 commits Jan 7, 2020
@bkuhl
bkuhl approved these changes Jan 8, 2020
@tompedals tompedals merged commit cd59087 into helpscout:develop Jan 9, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tompedals tompedals deleted the tompedals:oauth2-client-version2 branch Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.