Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New theme for Helpy by Seravo: Nordic #1059

Merged
merged 14 commits into from Jan 3, 2019

Conversation

Projects
None yet
6 participants
@cr0vy
Copy link
Contributor

cr0vy commented Dec 14, 2018

We currently use Flat theme on our hosted Helpy site. We’ve had a few issues with the Flat theme and need more features than the theme can currently provide. Those issues and features originate from the theme in use, so we started working on a new theme.
Nordic theme is fork of Flat theme. We have fixed some small issues and added few basic features we needed. This PR contains the base of theme and we will continue to improve it in the future.

What Nordic theme improves:
Search field on every page in Helpy
Gives customers an easy way to search for an another article, for example in different articles and on the category view.

Improve the accessibility of the language selection
Changing the language can now be done from any page without leaving the current page.
screenshot 2018-12-13 15 27 04

Cleaner URLs
The URLs have been shortened, for example from example.com/en/knowledgebase/1-example-category/docs/1-example-article to example.com/en/docs/1-example-article
screenshot 2018-12-13 15 28 04

Editing article via button
Admins can now go directly to editing from the the article page.
screenshot 2018-12-13 15 27 28

Legibility
Optimize typography to make support documentation as easy to read as possible.
screenshot 2018-12-13 15 26 51

@scott

This comment has been minimized.

Copy link
Member

scott commented Dec 14, 2018

This looks like a great contribution @cr0vy ! I will pull this and make any suggestions, as well as look at the Brakeman XSS warnings...

@scott

This comment has been minimized.

Copy link
Member

scott commented Dec 14, 2018

@ottok ottok force-pushed the Seravo:feature/nordic-theme branch from 88b4eef to 9771fb4 Dec 17, 2018

Update brakeman.ignore
Update brakeman.ignore file to circumvent false-positive from brakeman.
Also change line numbers for changed files.

The changes in the file were generated by brakeman -I
@elguitar

This comment has been minimized.

Copy link
Contributor

elguitar commented Dec 17, 2018

I pushed the brakeman ignores which are required to get past false-positive from brakeman in 34ff1ad.
Should it be corrected to the first commit and then build this branch again or is it fine like this?

@scott

This comment has been minimized.

Copy link
Member

scott commented Dec 17, 2018

It's fine like this!

@cr0vy

This comment has been minimized.

Copy link
Contributor Author

cr0vy commented Dec 21, 2018

We would like to know the current status of this PR, please? :)

Do you need us to do something @scott?

@scott scott merged commit ca739c6 into helpyio:master Jan 3, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ottok

This comment has been minimized.

Copy link

ottok commented Jan 3, 2019

Thanks @scott !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.