Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: with theme specified in ENV HELPY_THEME #1253

Merged
merged 1 commit into from Aug 9, 2019

Conversation

@azul
Copy link
Contributor

commented Apr 22, 2019

It is easy to break things in themes - for example with a typo in your views.
Allow running tests with a theme set in the HELPY_THEME environment variable.

Obviously some themes will not implement all functionality
or use different markup so that tests fail due to that.
Thinking about adding a skip_for_themes test helper for that.

For now being able to see which tests are failing for a given theme is helpful for me - maybe for others too.

test: with theme specified in ENV HELPY_THEME
It is easy to break things in themes - for example with a typo in your views.
Allow running tests with a theme set in the HELPY_THEME environment variable.

Obviously some themes will not implement all functionality
or use different markup so that tests fail due to that.
Thinking about adding a skip_for_themes test helper for that.

@scott scott added the 2.5 label Apr 30, 2019

@scott scott added 2.6 and removed 2.5 labels May 16, 2019

@scott scott merged commit 6eb6523 into helpyio:master Aug 9, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@azul azul deleted the azul:test-theme branch Aug 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.