-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for minifying JavaScript in generated HTML templates #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Correct 'posibilities' to 'possibilities' - Correct 'tradicional' to 'traditional' - Add additional element classes to allow show/hide styling - Add fallback fonts to CSS
- Add type hints - Replace exits with Exceptions - Remove commented code - Rename functions to have spaces where appropriate - 'repinyin' -> 'py_re' to match 'zy_re'
- Separate words in CSS selectors with hyphens - Delete commented code - 'writting' -> 'writing'
- Consolidate all CSS into one stylesheet - Correct underscores in selectors to hyphens - Move Persistence code to its own file - Move common functions to their own file - Wrap checking for Persistence in a common function - Generate requirements.txt using pip-tools (requirements.in)
- Change '#the-card' to '#root' - Always use Persistence.getItem(key) instead of just getItem() - Fix broken getElems references - Merge most front-side code into one common function - Clean up other front-side code
- Vital template comments are preserved - This relies on UglifyJS being installed and available in the shell on the generating machine - https://github.com/mishoo/UglifyJS#install
Superseded by #7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made this a separate pull request because it doesn't have anything directly to do with zhuyin, and because it requires UglifyJS to be installed on the generating machine.
Nothing seems to break because
/*EOL {{template}} EOL*/
comments are specifically preserved. I tried to find a pure Python minification library, but they were all old and/or unmaintained, and more importantly did not support preservation of comments. In any case UglifyJS is cross-platform and can be installed system-wide.