Fix flapping tests#54
Merged
Merged
Conversation
bafef0c to
91fc6d6
Compare
6 tasks
80095cf to
f8f2bcf
Compare
(partially cherry picked from commit 18eb3c6)
* fix: cspell ignore weird IPFS url * fix: cspell ignore filecoin f410f addresses * chore: write ignore in single line * feat: configure everything in `cspell.json` * refactor: remove unnecessary cspell ignores * refactor: cspell run command in actions and devcontainer * chore: enable editor support * chore: add comment * fix: cspell action options * feat: run for all files
(partially cherry-picked from f0fbeef)
(partially cherry picked from commit ebc3367)
8184dbf to
897cef9
Compare
There was a problem hiding this comment.
Pull request overview
This PR pulls in a set of upstream changes intended to reduce CI flakiness (notably around Solidity compiler downloads during tests) and to improve spell-checking consistency by centralizing cspell configuration and upgrading the GitHub Action.
Changes:
- Migrate spell-check configuration to
cspell.jsonand update the CI workflow to usecspell-actionv6 with repo-defined file globs. - Make several test-suite stability tweaks (timing adjustments, conditional Solidity test execution by
:chain_type, Tesla adapter setup/teardown). - Expand API v2 search controller tests (pagination, ENS/metadata/TAC microservice cases) and align response expectations to
address_hashfields.
Reviewed changes
Copilot reviewed 14 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
cspell.json |
Adds schema, file globs, regex ignores, and dictionary updates to centralize spell-check behavior. |
apps/indexer/test/indexer/fetcher/token_instance/realtime_test.exs |
Increases sleep to reduce timing-related flakes. |
apps/explorer/test/explorer/smart_contract/solidity/verifier_test.exs |
Gates Solidity verifier tests behind @chain_type == :default. |
apps/explorer/test/explorer/smart_contract/solidity/publisher_test.exs |
Gates Solidity publisher tests behind @chain_type == :default. |
apps/explorer/test/explorer/smart_contract/solidity/code_compiler_test.exs |
Gates Solidity compiler tests behind @chain_type == :default and adjusts Tesla adapter handling. |
apps/explorer/test/explorer/history/process_test.exs |
Adjusts timing interval and receive assertions to reduce flakiness. |
apps/explorer/priv/repo/migrations/20230905085809_drop_token_balances_tokens_foreign_key.exs |
Removes now-unnecessary cspell:ignore comment. |
apps/explorer/priv/repo/migrations/20230831122819_drop_current_token_balances_tokens_foreign_key.exs |
Removes now-unnecessary cspell:ignore comment. |
apps/explorer/priv/repo/migrations/20230821120625_drop_rest_address_foreign_keys.exs |
Removes now-unnecessary cspell:ignore comment. |
apps/explorer/priv/repo/migrations/20230817061317_drop_address_foreign_keys.exs |
Removes now-unnecessary cspell:ignore comment. |
apps/explorer/priv/repo/migrations/20230816061723_drop_token_transfers_and_transactions_address_foreign_key.exs |
Removes now-unnecessary cspell:ignore comment. |
apps/explorer/priv/repo/migrations/20230815131151_drop_logs_address_hash_foreign_key.exs |
Removes now-unnecessary cspell:ignore comment. |
apps/block_scout_web/test/block_scout_web/views/nft_helper_test.exs |
Adds a targeted cspell suppression comment. |
apps/block_scout_web/test/block_scout_web/controllers/api/v2/search_controller_test.exs |
Major expansion/refactor of API v2 search tests, including pagination, reputation filtering, ENS/metadata, and TAC microservice scenarios. |
.github/workflows/config.yml |
Upgrades cspell-action and switches workflow to use cspell.json file globs. |
.devcontainer/bin/bs |
Updates devcontainer spellcheck command to rely on default cspell config behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gndelia
approved these changes
May 21, 2026
ArturDolzan
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR is a collection of changes taken from upstream to ensure checks "Blockscout / Explorer Tests (optimism)" pass. The original problem is related to cache conditions when downloading the Solidity compilers during the tests making those to fail randomly. See blockscout#13230.
Changelog
This pull request updates spell checking configuration and related workflows, and makes minor test and code cleanups. The main changes are the migration to a new version of the cspell action with configuration moved to
cspell.json, improvements to spell checking coverage and accuracy, and minor test and comment adjustments.Spell checking improvements and configuration:
cspell-actionin.github/workflows/config.ymlto v6.11.1 and switched to using the centralizedcspell.jsonconfiguration file, enabling broader and more consistent spell checking across the codebase.cspell.jsonwith schema reference, enabled editor suggestions, specified file globs, used.gitignorefor exclusions, added ignore regex patterns, and expanded the custom dictionary. [1] [2] [3] [4] [5] [6]Test and code cleanups:
# cspell:ignorecomments from migration files, as these words are now handled in the dictionary. [1] [2] [3] [4] [5] [6]process_test.exsandrealtime_test.exsto improve reliability on slower machines. [1] [2] [3]:chain_typeand improved test setup/teardown for Tesla adapters. [1] [2] [3] [4] [5]Other minor changes:
cspell:disable-next-linecomment in an NFT helper test to suppress a specific spell check warning.Checklist for your Pull Request (PR)
masterin the Version column. If I removed variable, I added it to Deprecated ENV Variables page. After merging docs PR, changes will be reflected in these pages.