Permalink
Commits on Nov 28, 2012
  1. Update khan-site.css

    Test plan: Load an exercise in local mode, note that it looks reasonable and
    there's no longer a 404 when fetching the logo
    
    Auditors: alpert
    beneater committed Nov 28, 2012
Commits on Nov 27, 2012
  1. Get rid of unused currExerciseFilename variable.

    Test Plan:
    1. Load /exercises/parallel_lines_1.html
    2. Confirm it still works
    
    Reviewers: alpert
    
    Reviewed By: alpert
    
    CC: eater, emily
    
    Differential Revision: http://phabricator.khanacademy.org/D948
    Stephanie H. Chang committed Nov 27, 2012
Commits on Nov 26, 2012
  1. Fix summative exercises

    Summary:
    Add in an isSummative variable, that gets set correctly in both the app-engine
    and test-mode paths, which then decides the modules to load using the method
    devised in D946
    
    Test Plan:
    Try to load parallel_lines_1 in both app-engine and offline mode, see that it
    works
    
    Reviewers: eater, alpert
    
    Reviewed By: alpert
    
    CC: alpert
    
    Differential Revision: http://phabricator.khanacademy.org/D947
    xymostech committed Nov 26, 2012
  2. Bind to unload event after jQuery is loaded

    Summary: Local mode doesn't work without this.
    
    Test Plan: Opened an exercise in local mode and it loaded.
    
    Reviewers: james, emily, alpert
    
    Reviewed By: james
    
    CC: eater
    
    Differential Revision: http://phabricator.khanacademy.org/D944
    beneater committed Nov 26, 2012
Commits on Nov 23, 2012
  1. Fix matrix input appearance for wide #solutionarea

    In review mode, the answer area is significantly wider, so four of the
    textboxes would fit across in a single row. Since .matrix-row didn't
    properly clear floats, I made it do so and then moved the (absolutely
    positioned) brackets before the rows so that they would appear in the
    correct place.
    
    Test Plan:
    Look at multiplying_a_matrix_by_a_matrix.html, make #solutionarea wider
    in Chrome web inspector, see that the matrix still looks okay.
    
    Auditors: stephanie
    spicyj committed Nov 23, 2012
Commits on Nov 21, 2012
  1. Fix bug in khan-exercise.js where appropriate modules are not loaded …

    …as users navigate to new exercises via tutorial-nav
    
    Summary:
    This fixes two bugs:
        1. First, with khan-exercise.js. Essentially, the modules of all loaded exercises, instead of the current exercise, were being used in runModules(), which executes the functions of the form $.fn["module"], $.fn["moduleLoad"], and $.fn["moduleCleanup"]. As a result, the current exercise was compiled using modules for all loaded exercises. This bug had not been found earlier b/c matrix-input is pretty unique right now in visibly modifying the answer area & b/c the matrices tutorial contains both exercises that use and don't use it. This bug was probably slowing down fairly lightweight exercises that were in the same tutorial as heavy exercises (ex: using the word-problems package), since they were running $.fn["word-problemsLoad"] on every newProblem event.
        2. Make sure matrix-input events are not attached again when each hint is requested.
    
    There is room for improvement for whoever is brave enough to dive into this crazy mess of code.
    
    Test Plan:
    Devappserver:
        1. Visit /math/algebra/algebra-matrices/e/scalar_matrix_multiplication
        2. Navigate to "matrix dimensions" via tutorial nav
        3. Observe that the matrix input braces do not appear in the answer area
    
    Exercise land:
        1. Visit scalar_matrix_multiplication.html and matrix_dimensions.html
        2. Observe that nothing's visibly changed
    
    Reviewers: eater
    
    Reviewed By: eater
    
    CC: marcia, desmond
    
    Differential Revision: http://phabricator.khanacademy.org/D938
    Stephanie H. Chang committed Nov 21, 2012
Commits on Nov 20, 2012
  1. changed clearing of the cache to clear for all user exercises

    Summary: Changes needed for review K86121
    
    Test Plan: Added to that review
    
    Reviewers: kamens
    
    Reviewed By: kamens
    
    Differential Revision: http://phabricator.khanacademy.org/D933
    tzjames committed Nov 20, 2012
Commits on Nov 19, 2012
  1. Don't initialize matrix-input unless matrix-input module is explicitl…

    …y loaded
    
    Auditors: stephanie
    
    Test plan: In devappserver, load a non-matrix exercise and note the JS error,
    apply this fix, note the absense of the JS error, and that matrix input works
    for matrix exercises.
    beneater committed Nov 19, 2012
  2. Add video hint experiment for factoring_polynomials_1

    Summary: Add video hints, solution only, and steps only to the existing exercise with detailed hints
    
    Test Plan: Tested each locally
    
    Reviewers: stephanie
    
    Reviewed By: stephanie
    
    Differential Revision: http://phabricator.khanacademy.org/D929
    beneater committed Nov 19, 2012
  3. Remove empty examples from unit_circle

    I guess the old answer-types.js ignored this case
    
    Test plan: Previously hovering over "acceptable formats" in unit_circle showed
    a bullet with nothing next to it. After this fix, the "acceptable formats"
    doesn't appear.
    
    Auditors: emily
    beneater committed Nov 19, 2012
Commits on Nov 18, 2012
  1. Add exercises: Finding the determinant of a matrix, finding the inver…

    …se of a matrix
    
    Test Plan: Tested locally
    
    Reviewers: eater
    
    Reviewed By: eater
    
    Differential Revision: http://phabricator.khanacademy.org/D891
    Stephanie H. Chang committed Nov 18, 2012
Commits on Nov 16, 2012
  1. Merge pull request #33803 from xymostech/fix-fallback

    Fix fallbacks in answer types. fix #33883
    beneater committed Nov 16, 2012
  2. Restore acceptable format defaulting for multiple answer type

    In the case where a "multiple" answer-type doesn't have any examples defined
    and contains only one input element, inherit the acceptable formats from that
    single input element.
    
    Test Plan: Verify acceptable answers show up for
        http://localhost:8000/exercises/one_step_equations.html
    
    Auditors: emily
    beneater committed Nov 16, 2012
  3. Fix #33834 regression introduced by new answer-types.js

    The multiple answer type wasn't properly tracking data-forms for each element
    
    Test plan: Test http://localhost:8000/exercises/multiplying_mixed_numbers_1.html?debug&problem=0&seed=7 to verify that 23/3 is not accepted after this fix.
    
    Auditors: emily
    beneater committed Nov 16, 2012
Commits on Nov 15, 2012
  1. Fix fallbacks in answer types

    Because `undefined + ""` produces the string `"undefined"`, fallbacks
    did not accurately show that they were not available. This causes
    some/all of the problems to inaccurately never report that an answer was
    not entered. This should fix that.
    xymostech committed Nov 15, 2012
  2. Remove the solution fallback

    xymostech committed Nov 15, 2012
  3. Merge pull request #33787 from xymostech/fix-33675

    Fix width problems in reading_tables_2
    beneater committed Nov 15, 2012
  4. Lint

    xymostech committed Nov 15, 2012
Commits on Nov 14, 2012
  1. Copied over review D909. Added a comment.

    Summary: I didn't commit --amend, thought it would be easier just with a new branch.
    
    Test Plan: Same as in that review
    
    Reviewers: kamens
    
    Reviewed By: kamens
    
    Differential Revision: http://phabricator.khanacademy.org/D921
    tzjames committed Nov 14, 2012
  2. Sync exercises/khan-exercise.html

    Auditors: csilvers
    beneater committed Nov 14, 2012
  3. Convert .gif's to .png's in khan-exercises.

    Summary:
    The purpose of this conversion is to have (basically) only file format
    we use for images, to make our tools more effective.  For instance, we
    have a tool for compressing png's, but not gif's.
    
    We've already changed face-smiley to be a .png in stable, so this
    mirrors that.
    
    Reviewers: eater
    
    Reviewed By: eater
    
    Differential Revision: http://phabricator.khanacademy.org/D920
    csilvers committed Nov 14, 2012
  4. Fix a bunch of things

    Reviewers: emily
    
    Reviewed By: emily
    
    Differential Revision: http://phabricator.khanacademy.org/D904
    beneater committed Nov 14, 2012
  5. Forward slashes, not back

    Auditors: eater
    spicyj committed Nov 14, 2012
Commits on Nov 13, 2012
  1. Fix #33076 remove extraneous hint

    Summary: There's no reason for one-root to inherit from original
    
    Test Plan: Tested locally
    
    Reviewers: stephanie
    
    Reviewed By: stephanie
    
    Differential Revision: http://phabricator.khanacademy.org/D897
    beneater committed Nov 13, 2012
Commits on Nov 12, 2012
  1. Change capitalization of jQuery

    Auditors: csilvers
    spicyj committed Nov 12, 2012
  2. Fix typo

    Auditors: csilvers
    spicyj committed Nov 12, 2012
Commits on Nov 9, 2012
  1. Add some of Stephanie's new colors

    Test Plan: Tested locally
    
    Reviewers: stephanie
    
    Reviewed By: stephanie
    
    Differential Revision: http://phabricator.khanacademy.org/D908
    beneater committed Nov 9, 2012
  2. `*` -> `\times`

    Summary: We don't use or introduce '*' as meaning multiplication anywhere
    
    Test Plan: Local
    
    Reviewers: stephanie
    
    Reviewed By: stephanie
    
    Differential Revision: http://phabricator.khanacademy.org/D907
    beneater committed Nov 9, 2012
Commits on Nov 8, 2012
  1. Sync exercises/khan-exercise.html

    Test plan: cross fingers
    
    Auditors: alpert
    beneater committed Nov 8, 2012
Commits on Nov 6, 2012
  1. added a check to see if xhr exists, that will remove the out-of-date …

    …warning on the following page load
    
    Summary: This change will not solve people seeing the out-of-date warning message the first time, it may however fix the issue where people refresh the page and still see the out of date warning message.  Specifically if the xhr becomes undefined before this change an error was thrown and the cache never got cleared.  Deleting the fkey cookie was one way in which this seems to have happened.
    
    Test Plan: Went to an exercise in chrome or ff.  Deleted fkey cookie. Answered a question and an error was thrown saying xhr was undefined. Because the error was thrown the Khan exercise cache did not get cleared and the red message bar did not show up.  Then reloaded the page, the wrong problem number is reloaded from the cache, did an problem, and got another page is out of date warning - this time the red warning gets called and the cache gets cleared.  Subsequent reloads and all is fine.
    
    Reviewers: kamens
    
    Reviewed By: kamens
    
    Differential Revision: http://phabricator.khanacademy.org/D899
    tzjames committed Nov 6, 2012
Commits on Nov 2, 2012
  1. Don't ask about ambiguous triangles in law_of_sines

    Test Plan: Test http://localhost:8000/exercises/law_of_sines.html?seed=16&problem=find-angle&debug before and after
    
    Auditors: stephanie
    beneater committed Nov 2, 2012
Commits on Nov 1, 2012
  1. Merge pull request #32925 from xcvd/formatting_fixes

    Unclosed span tag
    beneater committed Nov 1, 2012
  2. Round correct answer in law_of_cosines to the nearest degree

    Test plan: tested locally with http://localhost:8000/exercises/law_of_cosines.html?seed=75&problem=sss-find-angle&debug
    
    Auditors: stephanie
    beneater committed Nov 1, 2012