New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verifying a signed message #88

Open
Fastidious opened this Issue Oct 24, 2016 · 10 comments

Comments

Projects
None yet
4 participants
@Fastidious

Fastidious commented Oct 24, 2016

What's this issue about?

Verifying a self signed message wrong strings.

Expected behavior

Show the name/email of the person that signed the message.

Actual behavior

Show undefined .

Steps to reproduce

Create key, sign a message, verify it.

Environment

macOS Sierra.

screen shot 2016-10-24 at 9 55 53 am

@frankcash

This comment has been minimized.

Collaborator

frankcash commented Oct 25, 2016

was the user part of your "Friends" list?

@Fastidious

This comment has been minimized.

Fastidious commented Oct 26, 2016

I was the user. I signed a message, and I verified it. That screenshot is the verification part.

@frankcash

This comment has been minimized.

Collaborator

frankcash commented Oct 26, 2016

Yes , we need to account for this. I know if you add yourself it will work.
If you'd like to submit a PR to fix this that would be great!

On Tue, Oct 25, 2016, 8:47 PM Fastidious notifications@github.com wrote:

I was the user. I signed a message, and I verified. That screenshot is the
verification part.


You are receiving this because you commented.

Reply to this email directly, view it on GitHub
#88 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFu9R9R6Ru5DHZx2fcCIOQSHchPbSGekks5q3qM2gaJpZM4Ke0cj
.

@Fastidious

This comment has been minimized.

Fastidious commented Oct 26, 2016

@frankcash if I knew, I would have submitted one to begin with. :-)

@ldabiralai

This comment has been minimized.

ldabiralai commented Oct 7, 2017

I just tried to reproduce this following the steps above and it seemed to work so we should close this, unless someone else can verify it as not working

@Fastidious

This comment has been minimized.

Fastidious commented Oct 7, 2017

@ldabiralai "it seemed to work?" This either works, or doesn't. This is still an issue. When someone produces a PR to account for this, that someone will close the issue.

@ldabiralai

This comment has been minimized.

ldabiralai commented Oct 8, 2017

@Fastidious I said it seemed to work because I'm not that well versed in the expected behaviour.

I followed the steps you described above and received this message:

image

I added my own public key to my contact list and then received this:

image

To me, both of these behaviours look correct..

@Fastidious

This comment has been minimized.

Fastidious commented Oct 8, 2017

@ldabiralai I should not need to be on the contact list to sign a message. Why will I need to be on my contact list? That is exactly what needs to be accounted for, which @frankcash noted on his comment.

@meMuszr

This comment has been minimized.

meMuszr commented Oct 12, 2017

Working on this if that's okay ~

@meMuszr

This comment has been minimized.

meMuszr commented Oct 15, 2017

npm-debug.log
Unfortunately couldn't even get this to run.. :\

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment