Exit status #9
Merged
Exit status #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le close". Files checked in: htseq2multx.pl tests/run_tests.sh tests/simulate_multx_error_test_27.pl
…it code of fastq-multx. Files checked in: Makefile.PL htseq2multx.pl tests/run_tests.sh tests/simulate_multx_error_test_27.pl tests/simulate_multx_non0_test_28.pl tests/test_data/test_27_error.out tests/test_data/test_27_summary.out tests/test_data/test_28_error.out tests/test_data/test_28_summary.out
|
I created an issue for "All checks have failed": #8 |
jcmatese
approved these changes
Aug 4, 2022
hepcat72
commented
Aug 4, 2022
|
@lparsons - Do you wish to have a look at this PR before I merge it and install on the cluster for HTSEQ to use? |
lparsons
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new version of IO::Pipe::Producer in order to accurately capture exit codes.
The previous version checked exit status, but that exit status was always 0 because it was the Producer fork parent ending without it returning the exit status of its child process, and that child process wasn't even attempting to get the exit status anyway. It may be that I had assumed it was getting the exit status of the command being executed.