Stateful Options (eg Authentication)

[theduke]

This library is a very cool idea.

One thing I would not know how to express: modifications that need to be made for each request, for example adding an Authentication header.

Any ideas how to express that smoothly?

[hephex]

Hi @theduke, thank you 😄 Sorry if I didn't reply earlier.

ATM you can make the auth headers part of the struct that implements the Api trait,
but I see that it's not a nice solution, and it could create a lot of duplicate code.

I'd like to keep this issue open a try to find a good solution. One option could be transforming the Api into a sort of prototype that you can clone and customise every time, so if you need to reuse the same request several times with different headers, you can reuse part of the existing request. I'll look into it to see if it's a suitable solution.

What do you think?

[hephex]

With this change, if you have an api request req you can use the method transform to create a request based on req that adds the header Authentication.

req.transform(
            |mut h: Headers| { h.insert("Authentication".to_string(), vec!["token123".to_string()]); h },
            identity::<Query>,
            identity::<io::Empty>
        );

Is this what you were looking for?

(I'll try to create a macro to make this transform nicer and readable.)