New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow admin to tweak restic restore helper image #638

Open
ncdc opened this Issue Jul 3, 2018 · 8 comments

Comments

Projects
None yet
5 participants
@ncdc
Copy link
Member

ncdc commented Jul 3, 2018

User Story

As a user of Ark with Restic, I would like to customize the restic container image that is deployed as an initContainer to Pods during a restore.


// TODO allow full image URL to be overriden via CLI flag.

Make it a flag to ark server?

@rosskukulinski

This comment has been minimized.

Copy link
Member

rosskukulinski commented Aug 8, 2018

As this isn't a breaking change, I don't think it must land in v1.0.0. Community contributions welcome if someone wants to accelerate the development of this feature.

@rosskukulinski rosskukulinski removed this from the v1.0.0 milestone Aug 8, 2018

@ljfranklin

This comment has been minimized.

Copy link

ljfranklin commented Nov 11, 2018

@ncdc @rosskukulinski I'd be willing to try a PR to add this flag. I'm trying to use Ark on a Raspberry Pi, the backup is working fine but the restore stumbles due to the restic helper image not supporting ARM. That said, I'm having trouble figuring out how to pass the image name from server.go down to restic_restore_action.go. It looks like this restic restore object is initialized in a separate run-plugins command and it seems awkward to pass the restic image name as a command line arg to run-plugins. Is there some config object that would make sense to hold a resticRestoreHelperImage property?

@patrickstjohn

This comment has been minimized.

Copy link

patrickstjohn commented Dec 21, 2018

+1 on this. This issue prevents restoration of restic backups on any internet segregated cluster.

@encryptedfear

This comment has been minimized.

Copy link

encryptedfear commented Jan 4, 2019

Hi,

If I made canges to the ark/pkg/restore/resti_restore_action.go, will it take effect on my next backup? Or is there another step that I've to do? I can't pull the image from gcr.io/heptio-images/ark-restic-restore-helper:v0.10.0 due to internet restrictions in our cluster.

@ncdc

This comment has been minimized.

Copy link
Member

ncdc commented Jan 4, 2019

@encryptedfear did you build a new ark image with your changes?

Another short-term option would be to pre-pull our image into your environment, then pre-load it onto all your nodes. I think that might work - unless the ImagePullPolicy (which we aren't setting) gets set to Always.

@encryptedfear

This comment has been minimized.

Copy link

encryptedfear commented Jan 9, 2019

Hi,

Sorry for the delay in response. No I haven't built one yet. Haven't been back to the office yet.
I'll try that approach, thanks.

@encryptedfear

This comment has been minimized.

Copy link

encryptedfear commented Jan 10, 2019

Hi @ncdc

As of the moment, there are far too many restrictions for me to build the image, as there are items to be white-listed on our side when I try to make update and make build alone. Is there any other way of changing the URL of the restic-restore-helper? In this case, the internet access is a void, unfortunately. We can only pull from a private Docker repository (where I've already pushed a copy of the restic-restore-helper image), and that's all the connection we can get on our side.

May I ask, is there a source file inside the image (of ark) that I can tweak via kubectl exec -it ark-container -- sh to change the URL only?

Cheers

@ncdc

This comment has been minimized.

Copy link
Member

ncdc commented Jan 10, 2019

@encryptedfear this requires a code change. We'll see if we can get a fix out for you soon.

@ncdc ncdc self-assigned this Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment