New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Cluster.AltStatName #827

Merged
merged 1 commit into from Dec 14, 2018

Conversation

Projects
None yet
2 participants
@pims
Contributor

pims commented Dec 5, 2018

Attempt at providing a solution for #689

Goal: Add support for Cluster.AltStatName to expose a more readable stat name.

Note: AltStatName does not seem to have the maximum length of a cluster name is limited to 60 limitation, so it is possible that the cluster name and the stat name differ slightly.

Feedback welcome!

@davecheney davecheney self-requested a review Dec 10, 2018

@davecheney

Hi,

Before I can review this I need you to sign your changes. Please squash your commits (so you only have one to sign) then git commit -a -s && git push -f

@pims pims force-pushed the pims:alt-stat-name branch 2 times, most recently from 55da5d8 to 6517c22 Dec 10, 2018

Add support for Cluster.AltStatName
Signed-off-by: tim <tim@fewagainstmany.com>

Fix gofmt

Signed-off-by: tim <tim@fewagainstmany.com>

@pims pims force-pushed the pims:alt-stat-name branch from 6517c22 to 20fa03f Dec 10, 2018

@pims

This comment has been minimized.

Contributor

pims commented Dec 10, 2018

@davecheney sorry about that. Hadn't realized that updating the the branch directly from Github UI would remove the sign-off. It's done now.

@davecheney davecheney added this to the 0.9.0 milestone Dec 10, 2018

@davecheney

This comment has been minimized.

Member

davecheney commented Dec 10, 2018

I'm going to mark this for review in 0.9 -- after kubecon -- I don't want to merge this into 0.8.1 as it changes the statistics format that 0.8 customers may be relying on.

@pims

This comment has been minimized.

Contributor

pims commented Dec 10, 2018

Sounds good.

@davecheney davecheney merged commit 20fa03f into heptio:master Dec 14, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
signed-off-by Commit has Signed-off-by
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment