Consider removal of E2E_SKIP default value
#875
Labels
Comments
johnSchnake
added a commit
that referenced
this issue
Sep 17, 2019
) With K8s v1.16, disruptive tests may not be part of the conformance suite. As a result we need to ensure that user workloads are protected by default while still allowing for CNCF certification test runs. In this PR we: - rename the default `conformance` mode to be `non-disruptive-conformance` and modified the skip list appropriately. - added a `certified-conformance` mode which does not provide a skip list and will run even the disruptive tests - tweaked the naming to use lower case values by default to be more consistent with our other flags/naming Fixes #877 Fixes #875 Signed-off-by: John Schnake <jschnake@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the solution you'd like
Upstream made an effort to ensure all conformance tests were properly tagged so that you didnt need to skip any tests to be a conformance run.
To support the older set of tests we delayed updating this so we still provide unnecessary env on the e2e test run that can be misleading (i.e. it implies that there are potentially Alpha conformance tests, or flakey conformance tests).
We will have to double-check what versions of k8s we support and when the upstream 'fixed' all the tests so conformance w/o a SKIP value was appropriate.
The text was updated successfully, but these errors were encountered: