Clarify conditional nature of restore in log #1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm also not sure if the changelogs file is necessary for fixes like this one. |
|
Because the solutions take different approaches, I'm happy to defer to whichever approach is most appropriate. My instinct is that the verbiage and placement of the logging I chose fits a bit better, but, again, I'm not certain about it. |
|
I think the verbiage that's in the other PR is better, but I'm happy to work with you here and proceed with this one. I'll add comments to the diffs. |
ncdc
suggested changes
Jan 10, 2019
|
I won't be able to finish reviewing this today/tomorrow, so I need to hand it off for now. @skriss can you take point? |
carlisia
reviewed
Jan 11, 2019
carlisia
reviewed
Jan 11, 2019
daved
force-pushed
the
fix/1142-restore_log
branch
2 times, most recently
from
c6593d9
to
e707e99
Compare
|
@carlisia |
skriss
suggested changes
Feb 7, 2019
Signed-off-by: Daved <daved@codemodus.com>
daved
force-pushed
the
fix/1142-restore_log
branch
from
e707e99
to
b2b1ee4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1142
I took a shot at this, but am green enough to not have much surety about the change.