New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add basic plugin panic handlers #1270
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems the way to do it 👍
LGTM! |
👍 will proceed with the rest. |
Updated the rest. Will squash before merge, and would like to do a quick manual test. |
Signed-off-by: Steve Kriss <krisss@vmware.com>
639ea14
to
abff244
Compare
Squashed, test looks fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, but should update copyright headers while we're here.
Signed-off-by: Steve Kriss <krisss@vmware.com>
Updated all, try out squash & merge when ready |
* add server-side panic handlers to all plugin methods Signed-off-by: Steve Kriss <krisss@vmware.com>
Fixes #521
@carlisia @nrb this is a basic fix for #521. It captures any info about the panic and returns it as a normal error. Stack traces (per Andy's WIP #1119) to be added in subsequent PR(s).
If this looks reasonable for
block_store.go
then i'll add it to the other 3 plugins as well.