Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest container image when version is empty #1439

Merged
merged 1 commit into from May 3, 2019

Conversation

Projects
None yet
3 participants
@nrb
Copy link
Member

commented May 3, 2019

Signed-off-by: Nolan Brubaker brubakern@vmware.com

@nrb nrb force-pushed the nrb:check-buildinfo branch from 134740b to 89ea823 May 3, 2019

@nrb nrb requested review from skriss and carlisia May 3, 2019

@skriss

skriss approved these changes May 3, 2019

Use latest container image when version is empty
When using `velero install`, the image used should be a reasonable
default, even if buildinfo.Version is missing (such as when using `go
build` directly).

Signed-off-by: Nolan Brubaker <brubakern@vmware.com>

@nrb nrb force-pushed the nrb:check-buildinfo branch from 89ea823 to 0fe82bd May 3, 2019

@carlisia
Copy link
Member

left a comment

🎉

@carlisia carlisia merged commit 884e512 into heptio:master May 3, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
signed-off-by Commit has Signed-off-by
Details

jessestuart added a commit to jessestuart/velero that referenced this pull request May 25, 2019

Merge remote-tracking branch 'upstream/master' into jesse/20190525
* upstream/master: (169 commits)
  Always pull the docker layers on image build
  add changelog for v1.0.0-rc.1
  Fix instances of 'an Velero' typo
  Add documentation for minio running in KinD
  Add flag to disable creation of VSL on install
  Document more restic limitations
  update build-from-scratch.md for clarity, velero install cmd (heptio#1458)
  Add new gauge to hold the timestamp of the last successful backup (heptio#1448)
  shortcut expander: use discovery helper's cached resource list
  add links to the configurable BSL/VSL params on install pages
  Add note about restic support being beta (heptio#1446)
  Check for backup existence before download (heptio#1447)
  Add note about backups stuck InProgress
  add v0.11.1-beta.1 changelog
  add v1.0.0-beta.1 changelog
  Use latest container image when version is empty (heptio#1439)
  add note about single credentials per provider to locations doc
  more docs updates (heptio#1432)
  remove ref to v0.10 from BSL validation error msg (heptio#1429)
  update docs/backup.md (heptio#1427)
  ...

jessestuart added a commit to jessestuart/velero that referenced this pull request May 28, 2019

Use latest container image when version is empty (heptio#1439)
When using `velero install`, the image used should be a reasonable
default, even if buildinfo.Version is missing (such as when using `go
build` directly).

Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.