Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for minio running in KinD #1465

Merged
merged 2 commits into from May 9, 2019
Merged

Conversation

nrb
Copy link
Contributor

@nrb nrb commented May 9, 2019

Fixes #1436

Signed-off-by: Nolan Brubaker brubakern@vmware.com

Copy link
Contributor

@carlisia carlisia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments

docs/get-started.md Outdated Show resolved Hide resolved
docs/get-started.md Outdated Show resolved Hide resolved
docs/get-started.md Show resolved Hide resolved
Fixes vmware-tanzu#1436

Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
Copy link
Contributor

@carlisia carlisia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, LGTM!

@skriss skriss merged commit a27e1a4 into vmware-tanzu:master May 9, 2019
@nrb nrb deleted the fix-1436 branch May 9, 2019 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add instructions for minio with KinD
3 participants