New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #26] create multiple session cookies #85

Merged
merged 2 commits into from Jan 16, 2019

Conversation

Projects
None yet
2 participants
@paulczar
Copy link
Contributor

paulczar commented Nov 27, 2018

When used with auth systems that create large keys (UAA) storing
sessions as cookies can cause the cookie to be larger than
browsers like. This somewhat awkwardly seperates id_token and
refresh_token out into their own cookies.

You could also switch out to filesystem or redis for session storage
but that adds more complication for runtime than this super simple use
case really warrants IMHO.

Signed-off-by: Paul Czarkowski username.taken@gmail.com

@paulczar

This comment has been minimized.

Copy link
Contributor Author

paulczar commented Nov 27, 2018

this addresses #26

@paulczar

This comment has been minimized.

Copy link
Contributor Author

paulczar commented Nov 27, 2018

will rebase when/if the other PRs are merged in.

@paulczar paulczar force-pushed the paulczar:more_sessions branch from 7bbeb0d to 72788b1 Nov 29, 2018

[Fix #26] create multiple session cookies
When used with auth systems that create large keys (UAA) storing
sessions as cookies can cause the cookie to be larger than
browsers like. This somewhat awkwardly seperates id_token and
refresh_token out into their own cookies.

You could also switch out to filesystem or redis for session storage
but that adds more complication for runtime than this super simple use
case really warrants IMHO.

Signed-off-by: Paul Czarkowski <username.taken@gmail.com>

@paulczar paulczar force-pushed the paulczar:more_sessions branch from 72788b1 to 561f374 Nov 29, 2018

@craigtracey craigtracey merged commit 107abb4 into heptiolabs:master Jan 16, 2019

0 of 2 checks passed

signed-off-by A commit in PR is missing Signed-off-by
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment