External component support PR #42
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yssey into external-components
|
@NoxNovus after summarizing the progress, let's close this PR for now to keep the PR list clean, we can re-open when it makes sense to work on this again. |
|
I've also tagged this commit, so we can safely delete the branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'd like to support loading external components.
Current progress (from @NoxNovus):
This PR contains the code for experimental arbitrary external component integration. In particular, Babel was used to support arbitrary transpilation of externally written React components into our bundled webpack code. Progress on this has been blocked primarily due to a lack of compatibility between Babel's outputted results and our dynamic rendering. The bulk of the code centers around a new Component, the ExternalLoader, which is intended to take transpiled external components and dynamically load them into Odyssey.
Some of this logic was later reused in FPTaylor integration, and that code may be of use for future progress here.