Make man page date reproducible #553
Conversation
cmake uses SOURCE_DATE_EPOCH for TIMESTAMP Makefile could use it as well as documented in https://reproducible-builds.org/docs/source-date-epoch/ Also use UTC to be independent of timezone. cmake codepath needs testing
| @@ -93,7 +93,7 @@ tar: doc | |||
|
|
|||
| doc/%.1 doc/%.7: doc/%.txt version.mk | |||
| $(call colorecho,DOC,$@) | |||
| $(VERBOSE) $(A2X) -f manpage -a "herbstluftwmversion=herbstluftwm $(VERSION)" -a "date=`date +%Y-%m-%d`" $< | |||
| $(VERBOSE) $(A2X) -f manpage -a "herbstluftwmversion=herbstluftwm $(VERSION)" -a "date=`date -u -r NEWS %Y-%m-%d`" $< | |||
There was a problem hiding this comment.
When using a file's modification date, I think one should use $< because the modification date of NEWS is independent from the man page modification date.
There was a problem hiding this comment.
I'm wrong for released versions. I think it is fine as it is!
|
Your changes improve the build system, and I don't want to discard your contribution. However, the development in the master branch is paused in favor of the winterbreeze branch, and the entire content of master will be discarded soon. The winterbreeze branch is "ahead of master" (in the git language), so I'd like not to commit to the master branch (except for bug fixes). You are welcome to do these changes in the winterbreeze branch (the resepctive file is |
Make man page date reproducible See https://reproducible-builds.org/ for why this is good CMake already uses `SOURCE_DATE_EPOCH` for `TIMESTAMP` The SOURCE_DATE_EPOCH variable is documented in https://reproducible-builds.org/docs/source-date-epoch/ Also use UTC to be independent of timezone. This is mostly a rebase of #553 that I finally managed to test on 0.9.0 now. This PR was done while working on [reproducible builds](https://reproducible-builds.org/) for [openSUSE](https://en.opensuse.org/openSUSE:Reproducible_Builds).
cmake already uses
SOURCE_DATE_EPOCHfor itsTIMESTAMPfunction.Makefile could use it as well as documented in
https://reproducible-builds.org/docs/source-date-epoch/
Note: cmake codepath needs testing. I only tested the Makefile part.