Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make man page date reproducible #563

Merged
merged 3 commits into from Jul 8, 2019

Conversation

@bmwiedemann
Copy link

commented Jul 8, 2019

Make man page date reproducible
See https://reproducible-builds.org/ for why this is good

CMake already uses SOURCE_DATE_EPOCH for TIMESTAMP
The SOURCE_DATE_EPOCH variable is documented in
https://reproducible-builds.org/docs/source-date-epoch/

Also use UTC to be independent of timezone.

Note: needs testing

bmwiedemann and others added some commits Jun 28, 2019

Make man page date reproducible
See https://reproducible-builds.org/ for why this is good

CMake already uses SOURCE_DATE_EPOCH for TIMESTAMP
The SOURCE_DATE_EPOCH variable is documented in
https://reproducible-builds.org/docs/source-date-epoch/

Also use UTC to be independent of timezone.
@t-wissmann

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

Great, thanks!

@mergify mergify bot merged commit 9a069f5 into herbstluftwm:winterbreeze Jul 8, 2019

2 checks passed

Summary 1 rule matches
Details
Travis CI - Pull Request Build Passed
Details

@bmwiedemann bmwiedemann deleted the bmwiedemann:date branch Jul 8, 2019

t-wissmann added a commit that referenced this pull request Jul 8, 2019

Revert "Make man page date reproducible (#563)"
This reverts commit 9a069f5.

I've reverted this because ths seems to lead to errors:

$ LC_ALL=C make -j8
-- Configuring done
-- Generating done
-- Build files have been written to: /home/thorsten/git/winterbreeze/debug
Scanning dependencies of target herbstluftwm
[  3%] Generating herbstluftwm-tutorial.7
[  3%] Building C object ipc-client/CMakeFiles/herbstclient.dir/main.c.o
[  4%] Generating herbstluftwm.1
[  6%] Generating herbstclient.1
[  8%] Generating herbstluftwm.html
[  9%] Generating herbstclient.html
/bin/sh: -c: line 0: syntax error near unexpected token `('
/bin/sh: -c: line 0: `cd /home/thorsten/git/winterbreeze/debug/doc && /usr/bin/cmake -E copy /home/thorsten/git/winterbreeze/doc/herbstluftwm.txt /home/thorsten/git/winterbreeze/debug/doc/herbstluftwm.txt STRING ( TIMESTAMP BUILD_DATE %Y-%m-%d UTC )'
make[2]: *** [doc/CMakeFiles/doc_man_herbstluftwm.dir/build.make:62: doc/herbstluftwm.1] Error 1
make[1]: *** [CMakeFiles/Makefile2:248: doc/CMakeFiles/doc_man_herbstluftwm.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
/bin/sh: -c: line 0: syntax error near unexpected token `('
/bin/sh: -c: line 0: `cd /home/thorsten/git/winterbreeze/debug/doc && /usr/bin/cmake -E copy /home/thorsten/git/winterbreeze/doc/herbstluftwm-tutorial.txt /home/thorsten/git/winterbreeze/debug/doc/herbstluftwm-tutorial.txt STRING ( TIMESTAMP BUILD_DATE %Y-%m-%d UTC )'
make[2]: *** [doc/CMakeFiles/doc_man_herbstluftwm-tutorial.dir/build.make:62: doc/herbstluftwm-tutorial.7] Error 1
make[1]: *** [CMakeFiles/Makefile2:211: doc/CMakeFiles/doc_man_herbstluftwm-tutorial.dir/all] Error 2
[ 11%] Generating herbstluftwm-tutorial.html
/bin/sh: -c: line 0: syntax error near unexpected token `('
/bin/sh: -c: line 0: `cd /home/thorsten/git/winterbreeze/debug/doc && /usr/bin/cmake -E copy /home/thorsten/git/winterbreeze/doc/herbstclient.txt /home/thorsten/git/winterbreeze/debug/doc/herbstclient.txt STRING ( TIMESTAMP BUILD_DATE %Y-%m-%d UTC )'
make[2]: *** [doc/CMakeFiles/doc_man_herbstclient.dir/build.make:62: doc/herbstclient.1] Error 1
make[1]: *** [CMakeFiles/Makefile2:359: doc/CMakeFiles/doc_man_herbstclient.dir/all] Error 2
@t-wissmann

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

I've temporarily reverted this commit again, because this leads to build failures here: 68199bd

@bmwiedemann

This comment has been minimized.

Copy link
Author

commented Jul 9, 2019

Maybe the STRING(TIMESTAMP needs to move further up? needs testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.