Make man page date reproducible #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://reproducible-builds.org/ for why this is good CMake already uses SOURCE_DATE_EPOCH for TIMESTAMP The SOURCE_DATE_EPOCH variable is documented in https://reproducible-builds.org/docs/source-date-epoch/ Also use UTC to be independent of timezone.
|
Great, thanks! |
t-wissmann
approved these changes
Jul 8, 2019
t-wissmann
added a commit
that referenced
this pull request
Jul 8, 2019
This reverts commit 9a069f5. I've reverted this because ths seems to lead to errors: $ LC_ALL=C make -j8 -- Configuring done -- Generating done -- Build files have been written to: /home/thorsten/git/winterbreeze/debug Scanning dependencies of target herbstluftwm [ 3%] Generating herbstluftwm-tutorial.7 [ 3%] Building C object ipc-client/CMakeFiles/herbstclient.dir/main.c.o [ 4%] Generating herbstluftwm.1 [ 6%] Generating herbstclient.1 [ 8%] Generating herbstluftwm.html [ 9%] Generating herbstclient.html /bin/sh: -c: line 0: syntax error near unexpected token `(' /bin/sh: -c: line 0: `cd /home/thorsten/git/winterbreeze/debug/doc && /usr/bin/cmake -E copy /home/thorsten/git/winterbreeze/doc/herbstluftwm.txt /home/thorsten/git/winterbreeze/debug/doc/herbstluftwm.txt STRING ( TIMESTAMP BUILD_DATE %Y-%m-%d UTC )' make[2]: *** [doc/CMakeFiles/doc_man_herbstluftwm.dir/build.make:62: doc/herbstluftwm.1] Error 1 make[1]: *** [CMakeFiles/Makefile2:248: doc/CMakeFiles/doc_man_herbstluftwm.dir/all] Error 2 make[1]: *** Waiting for unfinished jobs.... /bin/sh: -c: line 0: syntax error near unexpected token `(' /bin/sh: -c: line 0: `cd /home/thorsten/git/winterbreeze/debug/doc && /usr/bin/cmake -E copy /home/thorsten/git/winterbreeze/doc/herbstluftwm-tutorial.txt /home/thorsten/git/winterbreeze/debug/doc/herbstluftwm-tutorial.txt STRING ( TIMESTAMP BUILD_DATE %Y-%m-%d UTC )' make[2]: *** [doc/CMakeFiles/doc_man_herbstluftwm-tutorial.dir/build.make:62: doc/herbstluftwm-tutorial.7] Error 1 make[1]: *** [CMakeFiles/Makefile2:211: doc/CMakeFiles/doc_man_herbstluftwm-tutorial.dir/all] Error 2 [ 11%] Generating herbstluftwm-tutorial.html /bin/sh: -c: line 0: syntax error near unexpected token `(' /bin/sh: -c: line 0: `cd /home/thorsten/git/winterbreeze/debug/doc && /usr/bin/cmake -E copy /home/thorsten/git/winterbreeze/doc/herbstclient.txt /home/thorsten/git/winterbreeze/debug/doc/herbstclient.txt STRING ( TIMESTAMP BUILD_DATE %Y-%m-%d UTC )' make[2]: *** [doc/CMakeFiles/doc_man_herbstclient.dir/build.make:62: doc/herbstclient.1] Error 1 make[1]: *** [CMakeFiles/Makefile2:359: doc/CMakeFiles/doc_man_herbstclient.dir/all] Error 2
|
I've temporarily reverted this commit again, because this leads to build failures here: 68199bd |
|
Maybe the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Make man page date reproducible
See https://reproducible-builds.org/ for why this is good
CMake already uses
SOURCE_DATE_EPOCHforTIMESTAMPThe
SOURCE_DATE_EPOCHvariable is documented inhttps://reproducible-builds.org/docs/source-date-epoch/
Also use UTC to be independent of timezone.
Note: needs testing