Improve testing regexps

hercynium · Oct 23, 2013 · 3b6cef9 · 3b6cef9
1 parent 66d813c
commit 3b6cef9
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/t/readmeinbuild.t b/t/readmeinbuild.t
@@ -39,8 +39,8 @@ my %tests = (
     ],
     pod => [
         [ qr/^=head1\s+SYNOPSIS/m, "POD header" ],
-        [ qr/B<.*>/, "POD bold formatting" ],
-        [ qr/I<.*>/, "POD italic formatting" ],
+        [ qr/B<.*?>/, "POD bold formatting" ],
+        [ qr/I<.*?>/, "POD italic formatting" ],
     ],
     html => [
         [ qr/<html>/, "HTML code" ],
@@ -50,11 +50,12 @@ my %tests = (
     markdown => [
         [ qr/^# SYNOPSIS\s*$/m, "Markdown header" ],
         [ qr/__[^\s_]+__/, "Markdown bold formatting" ],
-        [ qr/[^_]_[^\s_]+_[^_]/, "Markdown italic formatting" ],
+        [ qr/(?<!_)_[^\s_]+_(?!_)/, "Markdown italic formatting" ],
     ],
     never => [
         [ qr/\r/, "Carriage return", ],
-    ]
+        [ qr/^__END__$/m, "Perl code __END__ marker", ],
+    ],
 );
 
 my @possible_types = keys %$Dist::Zilla::Plugin::ReadmeAnyFromPod::_types;

diff --git a/t/readmeinroot.t b/t/readmeinroot.t
@@ -39,8 +39,8 @@ my %tests = (
     ],
     pod => [
         [ qr/^=head1\s+SYNOPSIS/m, "POD header" ],
-        [ qr/B<.*>/, "POD bold formatting" ],
-        [ qr/I<.*>/, "POD italic formatting" ],
+        [ qr/B<.*?>/, "POD bold formatting" ],
+        [ qr/I<.*?>/, "POD italic formatting" ],
     ],
     html => [
         [ qr/<html>/, "HTML code" ],
@@ -50,11 +50,12 @@ my %tests = (
     markdown => [
         [ qr/^# SYNOPSIS\s*$/m, "Markdown header" ],
         [ qr/__[^\s_]+__/, "Markdown bold formatting" ],
-        [ qr/[^_]_[^\s_]+_[^_]/, "Markdown italic formatting" ],
+        [ qr/(?<!_)_[^\s_]+_(?!_)/, "Markdown italic formatting" ],
     ],
     never => [
         [ qr/\r/, "Carriage return", ],
-    ]
+        [ qr/^__END__$/m, "Perl code __END__ marker", ],
+    ],
 );
 
 my @possible_types = keys %$Dist::Zilla::Plugin::ReadmeAnyFromPod::_types;