Skip to content

Conversation

@andrey-kashcheev
Copy link
Contributor

Certificate settings for setting up SSL for CURL by using blobs

Relates-To: OLPEDGE-1750

@andrey-kashcheev andrey-kashcheev force-pushed the olpedge-1750-custom-cert branch 5 times, most recently from a551763 to c8727dd Compare May 29, 2023 15:59
@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Merging #1402 (8076bdc) into master (3c5794f) will decrease coverage by 0.11%.
The diff coverage is 69.40%.

❗ Current head 8076bdc differs from pull request most recent head dc0ed47. Consider uploading reports for the commit dc0ed47 to get more accurate results

@@            Coverage Diff             @@
##           master    #1402      +/-   ##
==========================================
- Coverage   80.71%   80.60%   -0.11%     
==========================================
  Files         337      337              
  Lines       12600    12781     +181     
  Branches     1360     1386      +26     
==========================================
+ Hits        10170    10302     +132     
- Misses       1881     1912      +31     
- Partials      549      567      +18     
Impacted Files Coverage Δ
.../include/olp/authentication/AuthenticationClient.h 100.00% <ø> (ø)
...ication/include/olp/authentication/TokenProvider.h 100.00% <ø> (ø)
...ntication/include/olp/authentication/TokenResult.h 100.00% <ø> (ø)
...pp-sdk-authentication/src/AuthenticationClient.cpp 100.00% <ø> (+8.33%) ⬆️
olp-cpp-sdk-core/include/olp/core/http/Network.h 100.00% <ø> (ø)
olp-cpp-sdk-core/src/client/OlpClient.cpp 87.19% <ø> (+0.23%) ⬆️
...p-sdk-core/src/client/OlpClientSettingsFactory.cpp 63.89% <0.00%> (-7.99%) ⬇️
...p-cpp-sdk-authentication/src/TokenEndpointImpl.cpp 82.63% <20.00%> (-0.31%) ⬇️
olp-cpp-sdk-authentication/src/TokenProvider.cpp 84.62% <33.33%> (-10.26%) ⬇️
olp-cpp-sdk-authentication/src/TokenResult.cpp 58.33% <50.00%> (-2.78%) ⬇️
... and 5 more

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@andrey-kashcheev andrey-kashcheev marked this pull request as ready for review June 12, 2023 13:23
@andrey-kashcheev andrey-kashcheev force-pushed the olpedge-1750-custom-cert branch 8 times, most recently from a0f295c to 910c8e8 Compare June 12, 2023 18:36
Certificate settings for setting up SSL for CURL by using blobs

Relates-To: OLPEDGE-1750
Signed-off-by: Andrey Kashcheev <ext-andrey.kashcheev@here.com>
@mykhailo-kuchma mykhailo-kuchma requested a review from Hsilgos June 13, 2023 07:37
@andrey-kashcheev andrey-kashcheev merged commit 3246241 into master Jun 13, 2023
@andrey-kashcheev andrey-kashcheev deleted the olpedge-1750-custom-cert branch June 13, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants