Skip to content
Permalink
Branch: master
Commits on May 24, 2019
  1. BundlerTest: Update an expected homepage URL

    sschuberth committed May 23, 2019
    Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
Commits on May 22, 2019
  1. model: Use annotations to add custom (de-)serializers

    sschuberth committed May 21, 2019
    This keeps all (de-)serialization code alongside the class.
    
    Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
  2. Gradle: Upgrade OkHttp to version 3.14.2

    sschuberth committed May 22, 2019
    See:
    
    https://github.com/square/okhttp/blob/master/CHANGELOG.md#version-3142
    
    Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
  3. Downloader: Fix an error message to make DownloaderTest pass again

    sschuberth committed May 21, 2019
    This changes the error message to like it was before eeea7ec so it again
    contains the name of the hash algorithm to make the DownloaderTest pass
    again.
    
    Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
  4. ScanCode: Move the error mapping funtions to the companion object

    sschuberth committed May 21, 2019
    These can be static, and this way they are defined close to their
    regexes.
    
    Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
  5. ScanCode: Improve a code comment position

    sschuberth committed May 21, 2019
    Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
Commits on May 20, 2019
  1. scanner: Rename getResult() to getRawResult()

    sschuberth committed May 20, 2019
    To better match the purpose and the corresponding "rawResult" property
    of the ScanResult class.
    
    Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
  2. LocalScanner: Document the getResult() and generateSummary() functions

    sschuberth committed May 20, 2019
    Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
  3. ScanCode: Remove obsolete TODOs

    sschuberth committed May 20, 2019
    Converting to other formats is done via reporters / will be done by the
    documenter. The license scan results already are part of the model by
    now.
    
    Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
  4. ScanCode: Use textValue() for values known to be textual

    sschuberth committed May 20, 2019
    We do not need nor want any conversion to happen in this case.
    
    Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
  5. Gradle: Do not refer to a (fun)testRuntime configuration

    sschuberth committed May 20, 2019
    There actually is no such configuration when using the Java Library
    Plugin, see
    
    https://docs.gradle.org/current/userguide/java_library_plugin.html#sec:java_library_configurations_graph
    
    Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
  6. Gradle: Avoid the functional test configuration to depend on the test…

    sschuberth committed May 20, 2019
    … output
    
    The functional tests are completely independent from the (unit) test
    output.
    
    Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
  7. Bundle the hash algorithm and value into an object for (de-)serializa…

    sschuberth committed May 15, 2019
    …tion
    
    This serializes new files as
    
        hash:
          value: "7c4f3c474fb2c041d8028740440937705ebb473a"
          algorithm: "SHA-1"
    
    while the old format of
    
        hash: "7c4f3c474fb2c041d8028740440937705ebb473a"
        hash_algorithm: "SHA-1"
    
    can still be deserialized.
    
    Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
Commits on May 17, 2019
  1. Gradle: Upgrade Jackson to version 2.9.9

    sschuberth committed May 17, 2019
    See https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.9.9.
    
    Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
Commits on May 15, 2019
  1. PipTest: Upgrade the expected Werkzeug version to 0.15.4

    sschuberth authored and mnonnenmacher committed May 15, 2019
    Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
  2. Also capture the Java version ORT is running on

    sschuberth authored and mnonnenmacher committed May 13, 2019
    This can be helpful to debug issues.
    
    Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
Commits on May 13, 2019
  1. cli: Bump the go-dep version to 0.5.1-1 in the Dockerfile

    sschuberth committed May 13, 2019
    To make it build again as the old version 0.5.0-1+B10 is gone from
    upstream.
    
    Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
  2. Gradle: Upgrade the Docker plugins to version 4.8.1

    sschuberth committed May 13, 2019
    See https://bmuschko.github.io/gradle-docker-plugin/#v4_8_1_may_11_2019.
    
    Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
Commits on May 10, 2019
  1. DotNet/NuGet: Decode SRI hashes

    sschuberth committed May 9, 2019
    The NuGet hashes are in fact SRI-style hashes that are Base64-encoded,
    so decode them.
    
    Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
Commits on May 9, 2019
  1. Hash: Remove a duplicate blank line

    sschuberth committed May 8, 2019
    Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
  2. Main: Write out "OSS Review Toolkit" in the CLI header

    sschuberth committed May 9, 2019
    We should have it spelled out here for visibility (and in case some one
    cannot read our nice ASCII art logo). This also aligns with the recently
    added header in the static HTML report.
    
    Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
  3. Add the ORT version and the creation time to the static HTML report

    sschuberth committed May 9, 2019
    Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
  4. static-html-reporter.css: Do not hard-code the font-weight for the wh…

    sschuberth committed May 9, 2019
    …ole body
    
    This breaks using tags like <strong>, and removing this does not seem to
    have any impact on the visual appearance of the report.
    
    Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
Commits on May 8, 2019
  1. init.gradle: Only pass required arguments for DependencyImpl in one m…

    sschuberth committed May 8, 2019
    …ore case
    
    Many arguments just match the custom default values here, so only pass
    the required arguments by name.
    
    Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
  2. init.gradle: Avoid using @immutable

    sschuberth committed May 8, 2019
    At least with Groovy 2.5 (which is used since Gradle 5.0), the
    map-constructor generated by @immutable behaves unexpectedly: Member
    variables for which no argument is passed do not maintain a custom value
    they are initialized with, but they are initialized with the default
    value for their type, which is null in most cases.
    
    Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
  3. Introduce a NONE hash to distinguish from UNKNOWN

    sschuberth committed May 7, 2019
    Previously, UNKNOWN was used for two cases:
    
    1) An existing hash value of an unknown hash algorithm.
    2) A non-existing hash value of no hash algorithm.
    
    However, for case 1) we can still compare actual and expected hash
    values by string even without knowing the algorithm. Because of this it
    makes sense to distinguish these two cases by introducing NONE for case
    2) and keeping UNKNOWN for case 1).
    
    Also fix test data accordingly so that only empty hash values use NONE.
    
    Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
  4. Pip: Improve logging in setupVirtualEnv()

    sschuberth committed May 8, 2019
    Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
Commits on May 6, 2019
  1. Improve code readability by consistently using orEmpty() calls

    sschuberth committed May 3, 2019
    Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
  2. ProcessCapture: Improve the error message fallback to stdout

    sschuberth authored and fviernau committed May 6, 2019
    Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
Commits on May 3, 2019
  1. SpdxExpression: Set only our own error listener also for the parser

    sschuberth committed May 2, 2019
    To suppress bogus console output like
    
        line 1:8 no viable alternative at input 'licensea'
    
    when running e.g. PackageCurationTest. This also results in more telling
    error messages.
    
    Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
  2. SpdxExpression: Inline the "visitor" variable

    sschuberth committed May 2, 2019
    Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
  3. SpdxExpression: Simplify code using "apply"

    sschuberth committed May 2, 2019
    Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
  4. SpdxExpressionParserTest: Slightly refactor code for easier debugging

    sschuberth committed May 2, 2019
    Simplify comparision to the expected type of expression.
    
    Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
  5. Pip: Write a meaningful error to the report if installing dependencie…

    sschuberth committed May 3, 2019
    …s fails
    
    Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
  6. DotNet/NuGet: Fix test projects to use an existing jQuery version

    sschuberth committed May 2, 2019
    If a non-existing version is used, NuGet falls back to using the most
    recent version. Using such non-existing versions in test is undesirable
    as it requires to update the tests whenever a new version is released.
    
    Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
Older
You can’t perform that action at this time.