Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on May 3, 2012
  1. @josevalim

    Merge pull request #6138 from bogdan/routes

    josevalim authored
    RouteSet: remove some code dups
  2. @jonleighton

    Merge pull request #6134 from carlosantoniodasilva/ar-relation-kernel…

    jonleighton authored
    …-private-methods
    
    Fix issue with private kernel methods and collection associations
  3. @carlosantoniodasilva

    Fix issue with private kernel methods and collection associations. Cl…

    carlosantoniodasilva authored
    …oses #2508
    
    Change CollectionProxy#method_missing to use scoped.public_send, to
    avoid a problem described in issue #2508 when trying to use class
    methods with names like "open", that clash with private kernel methods.
    Also changed the dynamic matcher instantiator to send straight to
    scoped, to avoid another roundtrip to method_missing.
  4. @spastorino

    Add CHANGELOG entry

    spastorino authored
  5. @spastorino

    Merge pull request #6131 from schneems/schneems/routes_backtrace

    spastorino authored
    Add backtrace to development routing error page
  6. @tenderlove

    Merge pull request #5153 from mhfs/first_finder_fix

    tenderlove authored
    Made `first` finder consistent among database engines by adding a default order
  7. @mhfs

    Use arel nodes instead of raw sql

    mhfs authored
  8. @mhfs
  9. @mhfs
  10. @mhfs
  11. @mhfs

    Document `last`, check for primary key on default order and use quote…

    mhfs authored
    …d table and column names
  12. @mhfs

    Made `first` finder consistent among database engines by adding a

    mhfs authored
    default order clause (fixes #5103)
Commits on May 2, 2012
  1. @schneems

    Add backtrace to development routing error page

    schneems authored
    If a user gets a routing error due to a view helper such as using user_path without an :id they must go to their logs to see the backtrace. By adding in the trace template, a user can see which line the error occurred on without leaving the browser.
    
    When a routing error occurs outside of the view the application trace will be blank and will not confuse developers.
  2. @pixeltrix

    Reset the request parameters after a constraints check

    pixeltrix authored
    A callable object passed as a constraint for a route may access the request
    parameters as part of its check. This causes the combined parameters hash
    to be cached in the environment hash. If the constraint fails then any subsequent
    access of the request parameters will be against that stale hash.
    
    To fix this we delete the cache after every call to `matches?`. This may have a
    negative performance impact if the contraint wraps a large number of routes as the
    parameters hash is built by merging GET, POST and path parameters.
    
    Fixes #2510.
  3. @josevalim

    Merge pull request #6125 from ncri/master

    josevalim authored
    Adding proc evaluation for action caching layout parameter
  4. @tenderlove

    Merge pull request #6122 from amerine/add_fetch_to_actiondispatch_htt…

    tenderlove authored
    …p_headers
    
    Enable ActionDispatch::Http::Headers to support fetch
  5. @tenderlove

    * move exception message to exception constructor

    tenderlove authored
    * save original exception
    * keep original backtrace
  6. @drogus

    Merge pull request #3707 from ebeigarts/refactor_remove_column

    drogus authored
    Refactored remove_column
  7. @amerine
  8. @bogdan
  9. @jeremy

    Merge pull request #6119 from romanvbabenko/refactor/checking_rubygem…

    jeremy authored
    …s_presence
    
    Gem const presence checking has been removed
  10. @jeremy

    Merge pull request #6116 from romanvbabenko/refactor/executable_rakef…

    jeremy authored
    …iles
    
    Rakefile executable attributes and shebang lines has been removed
  11. @josevalim

    Merge pull request #6121 from bogdan/routes

    josevalim authored
    ActionPack routes: remove some useless code.
  12. @bogdan
  13. @josevalim

    Merge pull request #6120 from arunagw/build_fix_master_railties

    josevalim authored
    Fix build for railties generators
  14. @arunagw
  15. @josevalim

    Merge pull request #6118 from arunagw/build_fix_master

    josevalim authored
    build fix for SharedGeneratorTests
  16. @arunagw
  17. @romanvbabenko
  18. @romanvbabenko
  19. @josevalim

    Merge pull request #6040 from Paymium/issue-6033

    josevalim authored
    BigDecimal string wrapping in JSON serialization can now be opted-out
  20. @josevalim

    Merge pull request #5962 from bogdan/routes

    josevalim authored
    Remove tests for undocumented private methods
  21. @josevalim

    Merge pull request #6111 from oscardelben/new_hash_syntax_in_gemfile

    josevalim authored
    Use new hash syntax in generated Gemfile
  22. @oscardelben
Something went wrong with that request. Please try again.