Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account Prefer Command::status over output #141

merged 1 commit into from Jun 16, 2021


Copy link

This replaces Command::output with Command::status in

Collecting and relaying stdout and stderr like before is not necessary, as stdout and stderr are inherited from the parent with status. Inner failures are now displayed more nicely.

@mkroening mkroening requested a review from stlankes June 14, 2021 15:46
@mkroening mkroening self-assigned this Jun 14, 2021
Copy link
Member Author

I force-pushed on accident, but the content of the commit is the same as before.

Copy link

@stlankes stlankes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

Copy link

bors bot commented Jun 16, 2021

@bors bors bot merged commit 562956e into hermit-os:master Jun 16, 2021
@mkroening mkroening deleted the build-rs-status branch January 20, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants